Re: eu- prefix by default (Was; Re: elfutils build error)

[Mark Wielaard <mjw@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 775 bytes --]

On Fri, 2016-02-26 at 14:43 -0800, Jose E. Marchesi wrote:
>     I would recommend using something like configure
>     --prefix=/usr/local/elfutils --program-prefix=eu-
>     to install under /usr/local/elfutils and have all programs start with
>     eu-... so they don't clash with any existing ones.
>
> And speaking of that... what about setting the program-prefix to eu- by
> default?
> 
> Almost no one wants the elfutils to replace binutils, but to complement
> them.  But that can happen by accident very easily with the default
> program names.
>    
> Also, we are so used to use eu-stack and the other eu-* commands that
> using stack, etc feels weird :)
> 
> What you people think?

Good idea. How about the following patch?

Cheers,

Mark

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-config-Use-program-prefix-eu-by-default.patch --]
[-- Type: text/x-patch, Size: 2401 bytes --]

From b10e6ad85dd03ec900280d7383f62f4ad529237b Mon Sep 17 00:00:00 2001
From: Mark Wielaard <mjw@redhat.com>
Date: Wed, 2 Mar 2016 15:04:43 +0100
Subject: [PATCH] config: Use --program-prefix=eu- by default.

We want eu- as default program prefix if none was given by the user.
But if the user explicitly provided --program-prefix="" then pretend
it wasn't set at all (NONE).

This makes sure all tools will be installed as eu-<program>.
We want this default since most tools would normally conflict with
the GNU binutils variants that have similar names.

Signed-off-by: Mark Wielaard <mjw@redhat.com>
---
 ChangeLog    |  5 +++++
 NEWS         |  5 +++++
 configure.ac | 13 +++++++++++++
 3 files changed, 23 insertions(+)

diff --git a/ChangeLog b/ChangeLog
index 07b525c..9661977 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2016-03-02  Mark Wielaard  <mjw@redhat.com>
+
+	* configure.ac: Set program_prefix to eu- by default.
+	* NEWS (0.166): New sections, document --program-prefix default.
+
 2016-02-13  Mark Wielaard  <mjw@redhat.com>
 
 	* configure.ac: Add check for whether gcc accepts -Wnull-dereference.
diff --git a/NEWS b/NEWS
index 53fe364..1a55d3a 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,8 @@
+Version 0.166
+
+config: The default program prefix for the installed tools is now eu-.
+        Use configure --program-prefix="" to not use a program prefix.
+
 Version 0.165
 
 elfcompress: New utility to compress or decompress ELF sections.
diff --git a/configure.ac b/configure.ac
index df58b5b..dd510a0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -19,6 +19,19 @@ dnl  You should have received a copy of the GNU General Public License
 dnl  along with this program.  If not, see <http://www.gnu.org/licenses/>.
 AC_INIT([elfutils],[0.165],[https://bugzilla.redhat.com/],[elfutils])
 
+# We want eu- as default program prefix if none was given by the user.
+# But if the user explicitly provided --program-prefix="" then pretend
+# it wasn't set at all (NONE). We want to test this really early before
+# configure has a chance to use the value.
+
+if test "x$program_prefix" = "xNONE"; then
+  AC_MSG_NOTICE([No --program-prefix given, using "eu-"])
+  program_prefix="eu-"
+elif test "x$program_prefix" = "x"; then
+  AC_MSG_NOTICE([Using no program-prefix])
+  program_prefix=NONE
+fi
+
 AC_CONFIG_AUX_DIR([config])
 AC_CONFIG_FILES([config/Makefile])
 
-- 
1.8.3.1