Re: eu- prefix by default (Was; Re: elfutils build error)

Re: eu- prefix by default (Was; Re: elfutils build error)

[Mark Wielaard]

[-- Attachment #1: Type: text/plain, Size: 767 bytes --]

On Wed, 2016-03-02 at 08:00 -0800, Jose E. Marchesi wrote:
>     > And speaking of that... what about setting the program-prefix to eu- by
>     > default?
>     > 
>     > Almost no one wants the elfutils to replace binutils, but to complement
>     > them.  But that can happen by accident very easily with the default
>     > program names.
>     >    
>     > Also, we are so used to use eu-stack and the other eu-* commands that
>     > using stack, etc feels weird :)
>     > 
>     > What you people think?
>     
>     Good idea. How about the following patch?
> 
> Sweet.  Install it! :D

OK, pushed to master.
It passed make distcheck, so it must be perfect.

Please do let me know if it causes any issues for anybody.

Thanks,

Mark

Re: eu- prefix by default (Was; Re: elfutils build error)

[Jose E. Marchesi]

[-- Attachment #1: Type: text/plain, Size: 523 bytes --]


    > And speaking of that... what about setting the program-prefix to eu- by
    > default?
    > 
    > Almost no one wants the elfutils to replace binutils, but to complement
    > them.  But that can happen by accident very easily with the default
    > program names.
    >    
    > Also, we are so used to use eu-stack and the other eu-* commands that
    > using stack, etc feels weird :)
    > 
    > What you people think?
    
    Good idea. How about the following patch?

Sweet.  Install it! :D

Re: eu- prefix by default (Was; Re: elfutils build error)

[Mark Wielaard]

[-- Attachment #1: Type: text/plain, Size: 775 bytes --]

On Fri, 2016-02-26 at 14:43 -0800, Jose E. Marchesi wrote:
>     I would recommend using something like configure
>     --prefix=/usr/local/elfutils --program-prefix=eu-
>     to install under /usr/local/elfutils and have all programs start with
>     eu-... so they don't clash with any existing ones.
>
> And speaking of that... what about setting the program-prefix to eu- by
> default?
> 
> Almost no one wants the elfutils to replace binutils, but to complement
> them.  But that can happen by accident very easily with the default
> program names.
>    
> Also, we are so used to use eu-stack and the other eu-* commands that
> using stack, etc feels weird :)
> 
> What you people think?

Good idea. How about the following patch?

Cheers,

Mark

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-config-Use-program-prefix-eu-by-default.patch --]
[-- Type: text/x-patch, Size: 2401 bytes --]

From b10e6ad85dd03ec900280d7383f62f4ad529237b Mon Sep 17 00:00:00 2001
From: Mark Wielaard <mjw@redhat.com>
Date: Wed, 2 Mar 2016 15:04:43 +0100
Subject: [PATCH] config: Use --program-prefix=eu- by default.

We want eu- as default program prefix if none was given by the user.
But if the user explicitly provided --program-prefix="" then pretend
it wasn't set at all (NONE).

This makes sure all tools will be installed as eu-<program>.
We want this default since most tools would normally conflict with
the GNU binutils variants that have similar names.

Signed-off-by: Mark Wielaard <mjw@redhat.com>
---
 ChangeLog    |  5 +++++
 NEWS         |  5 +++++
 configure.ac | 13 +++++++++++++
 3 files changed, 23 insertions(+)

diff --git a/ChangeLog b/ChangeLog
index 07b525c..9661977 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2016-03-02  Mark Wielaard  <mjw@redhat.com>
+
+	* configure.ac: Set program_prefix to eu- by default.
+	* NEWS (0.166): New sections, document --program-prefix default.
+
 2016-02-13  Mark Wielaard  <mjw@redhat.com>
 
 	* configure.ac: Add check for whether gcc accepts -Wnull-dereference.
diff --git a/NEWS b/NEWS
index 53fe364..1a55d3a 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,8 @@
+Version 0.166
+
+config: The default program prefix for the installed tools is now eu-.
+        Use configure --program-prefix="" to not use a program prefix.
+
 Version 0.165
 
 elfcompress: New utility to compress or decompress ELF sections.
diff --git a/configure.ac b/configure.ac
index df58b5b..dd510a0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -19,6 +19,19 @@ dnl  You should have received a copy of the GNU General Public License
 dnl  along with this program.  If not, see <http://www.gnu.org/licenses/>.
 AC_INIT([elfutils],[0.165],[https://bugzilla.redhat.com/],[elfutils])
 
+# We want eu- as default program prefix if none was given by the user.
+# But if the user explicitly provided --program-prefix="" then pretend
+# it wasn't set at all (NONE). We want to test this really early before
+# configure has a chance to use the value.
+
+if test "x$program_prefix" = "xNONE"; then
+  AC_MSG_NOTICE([No --program-prefix given, using "eu-"])
+  program_prefix="eu-"
+elif test "x$program_prefix" = "x"; then
+  AC_MSG_NOTICE([Using no program-prefix])
+  program_prefix=NONE
+fi
+
 AC_CONFIG_AUX_DIR([config])
 AC_CONFIG_FILES([config/Makefile])
 
-- 
1.8.3.1

Re: eu- prefix by default (Was; Re: elfutils build error)

[phi gcc]

[-- Attachment #1: Type: text/plain, Size: 2322 bytes --]

I think we need to understand how people who build the elfutils use them.

1) Distro owner make them then package it then test/deliver it.
That the one that comes as binary on my machine and I would use to
check the a.out I am producing on my machine.

2) Developper who need to inspect a.out he/she didn't produced. In my
case I am loged on a development machine, and I receive a.out I didn't
produced locally (linux kernels comming from various distro, with
kernel ranging from 2.6.1x to 4.x my dev machine seating somewhere in
the middle.

I need to build locally an elfutils, generally the latest one that is
able to read the old a.out (old dwarf, i.e dwarf 2) and I can also
read very recent a.out i.e dwarf4.

When I buid those very latest elfutils, I dont want to temper with the
binary that comes with my distro, and I don't want to type very long
name, yet this later I can use aliases so it is not a real argument.

Well I figured that with a descent environment (No '.' in PATH) and I
can build elfutils, I figured that by hacking the makefile we can
build archived so I can move my build around on other nodes if needed,
and that my binaries are located in src/ not really the place I
imagined :)

All in all now I am operational with elfutils and it is a very good tools set.

Cheers,
Phi



On Fri, Feb 26, 2016 at 11:43 PM, Jose E. Marchesi
<jose.marchesi@oracle.com> wrote:
>
>
>     On Fri, 2016-02-26 at 21:11 +0100, phi gcc wrote:
>     > I didn't made a make install on purpose may I shoul but I don't want
>     > to push things built here on my system...
>     > Whant to build pure local under the tar xv dir
>
>     I would recommend using something like configure
>     --prefix=/usr/local/elfutils --program-prefix=eu-
>     to install under /usr/local/elfutils and have all programs start with
>     eu-... so they don't clash with any existing ones.
>
>
> And speaking of that... what about setting the program-prefix to eu- by
> default?
>
> Almost no one wants the elfutils to replace binutils, but to complement
> them.  But that can happen by accident very easily with the default
> program names.
>
> Also, we are so used to use eu-stack and the other eu-* commands that
> using stack, etc feels weird :)
>
> What you people think?

eu- prefix by default (Was; Re: elfutils build error)

[Jose E. Marchesi]

[-- Attachment #1: Type: text/plain, Size: 864 bytes --]



    On Fri, 2016-02-26 at 21:11 +0100, phi gcc wrote:
    > I didn't made a make install on purpose may I shoul but I don't want
    > to push things built here on my system...
    > Whant to build pure local under the tar xv dir
    
    I would recommend using something like configure
    --prefix=/usr/local/elfutils --program-prefix=eu-
    to install under /usr/local/elfutils and have all programs start with
    eu-... so they don't clash with any existing ones.


And speaking of that... what about setting the program-prefix to eu- by
default?

Almost no one wants the elfutils to replace binutils, but to complement
them.  But that can happen by accident very easily with the default
program names.
   
Also, we are so used to use eu-stack and the other eu-* commands that
using stack, etc feels weird :)

What you people think?