From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============0622574743130360353==" MIME-Version: 1.0 From: Mark Wielaard To: elfutils-devel@lists.fedorahosted.org Subject: Re: [PATCH] Do not depend on non-POSIX features Date: Wed, 12 Oct 2016 16:41:05 +0200 Message-ID: <1476283265.21750.165.camel@redhat.com> In-Reply-To: 1476282122.21750.162.camel@redhat.com --===============0622574743130360353== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Wed, 2016-10-12 at 16:22 +0200, Mark Wielaard wrote: > I am no fan of redefining/open coding things which reasonable can be > expected to be provided through normal GNU system headers/libs. But > these seem fairly minor. However if there are larger changes needed we > should probably pull in the relevant gnulib modules. Hmmm, I remember why I don't like such conditional defines/code. The configure check was wrong... It should be: diff --git a/configure.ac b/configure.ac index feb2ed5..5360447 100644 --- a/configure.ac +++ b/configure.ac @@ -245,7 +245,9 @@ zip_LIBS=3D"$LIBS" LIBS=3D"$save_LIBS" AC_SUBST([zip_LIBS]) = -AC_CHECK_DECLS([memrchr rawmemchr]) +AC_CHECK_DECLS([memrchr, rawmemchr],[],[], + [#define _GNU_SOURCE + #include ]) AC_CHECK_DECLS(powerof2, , , [#include ]) = AC_CHECK_LIB([stdc++], [__cxa_demangle], [dnl At least now we know the fallback code really works, but please explicitly say what kind of environment you tested on (and which you didn't) next time. Thanks, Mark --===============0622574743130360353==--