public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mjw@redhat.com>
To: elfutils-devel@lists.fedorahosted.org
Subject: Re: [PATCH 2/2] tests: unstrip: Add test for mismatched .strtab sections
Date: Mon, 24 Oct 2016 13:14:42 +0200	[thread overview]
Message-ID: <1477307682.4244.5.camel@redhat.com> (raw)
In-Reply-To: 1477243556-32858-2-git-send-email-cernekee@chromium.org

[-- Attachment #1: Type: text/plain, Size: 558 bytes --]

On Sun, 2016-10-23 at 10:25 -0700, Kevin Cernekee wrote:
> Current unstrip test cases either have no .symtab/.strtab in the
> stripped binary, or .strtab sections that are identical between the
> stripped and debuginfo binaries.  Add a test case where .symtab/.strtab
> in the stripped binary contains a small subset of the full unstripped
> data.

Good to see real world testfiles. It made making sure your patch really
fixed the issue that much easier. Pushed to master.

> Signed-off-by: Kevin Cernekee <cernekee@chromium.org>

Thanks,

Mark

             reply	other threads:[~2016-10-24 11:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-24 11:14 Mark Wielaard [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-10-23 17:32 Kevin Cernekee
2016-10-23 17:25 Kevin Cernekee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1477307682.4244.5.camel@redhat.com \
    --to=mjw@redhat.com \
    --cc=elfutils-devel@lists.fedorahosted.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).