From: Mark Wielaard <mark@klomp.org>
To: elfutils-devel@lists.fedorahosted.org
Subject: Re: libelf gelf_newehdr and gelf_newphdr return types
Date: Tue, 06 Dec 2016 14:47:32 +0100 [thread overview]
Message-ID: <1481032052.15612.27.camel@klomp.org> (raw)
In-Reply-To: 4c709e12-a549-7080-5d82-57cd81c72c67@Oracle.COM
[-- Attachment #1: Type: text/plain, Size: 800 bytes --]
On Fri, 2016-12-02 at 13:39 -0700, Ali Bahrami wrote:
> Although uintptr_t would work, it seems unnecessary. Note that freebsd
> already uses 'void *', and surely they build most of the same ELF-related
> FOSS code that we might be concerned about, so I think that the libelf
> code already has ported easily. As such, and given that 'void *' is the
> common C idiom for this sort of use, I think it would make sense to
> use it.
I was leaning towards using uintptr_t. But given that other libelf
implementations use void * already for the return type of these two
functions it does seem better to just consolidate on that. It also seems
more in line with the original intent of the gelf functions (return a
pointer to the newly constructed header or NULL of failure).
Cheers,
Mark
next reply other threads:[~2016-12-06 13:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 13:47 Mark Wielaard [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-12-06 23:41 Ali Bahrami
2016-12-06 23:09 Mark Wielaard
2016-12-06 16:45 Ali Bahrami
2016-12-06 14:31 Mark Wielaard
2016-12-03 22:02 Kurt Roeckx
2016-12-03 21:05 Ali Bahrami
2016-12-02 20:39 Ali Bahrami
2016-12-02 20:25 Ali Bahrami
2016-12-02 19:00 Josh Stone
2016-12-02 9:42 Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481032052.15612.27.camel@klomp.org \
--to=mark@klomp.org \
--cc=elfutils-devel@lists.fedorahosted.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).