From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104184 invoked by alias); 17 Feb 2017 09:46:27 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 104167 invoked by uid 89); 17 Feb 2017 09:46:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=reluctantly, our X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: mx1.redhat.com Message-ID: <1487324782.10240.29.camel@redhat.com> Subject: Re: [PATCH] Check for existence of mempcpy From: Mark Wielaard To: Ulf Hermann Cc: elfutils-devel@sourceware.org Date: Fri, 17 Feb 2017 09:46:00 -0000 In-Reply-To: <8d7f6ec7-205c-e196-900a-3cf26a02c691@qt.io> References: <8d7f6ec7-205c-e196-900a-3cf26a02c691@qt.io> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 17 Feb 2017 09:46:25 +0000 (UTC) X-SW-Source: 2017-q1/txt/msg00049.txt.bz2 On Thu, 2017-02-16 at 10:10 +0100, Ulf Hermann wrote: > If it doesn't exist, provide a definition based on memcpy. Applied, but slightly reluctantly. I have no way to test this. And it will evaluate the last argument (n) twice. Which seems to not matter in the current calls in our codebase. But it might subtly break something if someone forgets. Cheers, Mark