From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104837 invoked by alias); 17 Feb 2017 10:26:57 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 104815 invoked by uid 89); 17 Feb 2017 10:26:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: mx1.redhat.com Message-ID: <1487327210.10240.36.camel@redhat.com> Subject: Re: [PATCH] Move print_version into printversion.{h|c} From: Mark Wielaard To: Ulf Hermann Cc: elfutils-devel@sourceware.org Date: Fri, 17 Feb 2017 10:26:00 -0000 In-Reply-To: <2663918e-b64e-fc56-1547-47de8d1bb2db@qt.io> References: <2663918e-b64e-fc56-1547-47de8d1bb2db@qt.io> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 17 Feb 2017 10:26:52 +0000 (UTC) X-SW-Source: 2017-q1/txt/msg00055.txt.bz2 On Thu, 2017-02-16 at 12:32 +0100, Ulf Hermann wrote: > Rename version.c so that the implementation is called after the header > and the header doesn't clash with the toplevel version.h. print_version > depends on argp and is only used in the tools. Applied, because the split itself is fine. But like said before argp is needed for the tools and the libdw interface. If your glibc replacement doesn't provide argp the build should pick up libargp and get the definitions and implementation from there. Cheers, Mark