From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id E74973858C54 for ; Tue, 17 Oct 2023 15:05:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E74973858C54 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E74973858C54 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=45.83.234.184 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697555102; cv=none; b=hoh4bS2OGZGe7fRrBS5lqTexo8z76ApuyIvmgrcVYGBKShzZBkyDepQBV7xOFoPUOG1Giy09GSuh3eiPuOG6VpCD8CoskjCW014t7J5N7NgD3pFGqlZsJk09LwXFdqtmrBcLTHnHoDYYVOxAK+wbKDNw5sXoihJ9WGridpswOF0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697555102; c=relaxed/simple; bh=CZghJKU5TEozF7EhFylMr7v2qt134r6ndOJAK9w+2tI=; h=Message-ID:Subject:From:To:Date:MIME-Version; b=cjXsF9wQ+gDJOjdOowmMKsvOk+xzNi88uvDouTEIWWPOJvH3cnsPoyOqJv/cQ3b6VYXqFQsBENwnr/js8n+x0B0v14h64602Jkga92qX8pyLdqgS3JZ4G8cz+6oSw6X1Rf87Ard2b6ZFJhfOBVz3jIDkDyM+FddO3mzLEyJGtso= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from r6.localdomain (82-217-174-174.cable.dynamic.v4.ziggo.nl [82.217.174.174]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 94BC9300058A; Tue, 17 Oct 2023 17:04:59 +0200 (CEST) Received: by r6.localdomain (Postfix, from userid 1000) id 14836340318; Tue, 17 Oct 2023 17:04:59 +0200 (CEST) Message-ID: <148b3091dfad0bb7f517dceccf3e744e7c73505e.camel@klomp.org> Subject: Re: [PATCH] Fix thread-safety for elfutils From: Mark Wielaard To: Heather McIntyre Cc: elfutils-devel@sourceware.org, John Mellor-Crummey Date: Tue, 17 Oct 2023 17:04:58 +0200 In-Reply-To: References: <301fac87e83ebbbd677750579ae9a3429b461bdf.camel@klomp.org> <7e00014702b125aa4a9e0cc4534e1bffdbbe3d0a.camel@klomp.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-Spam-Status: No, score=-3026.9 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,KAM_SHORT,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Heather, On Sat, 2023-10-14 at 13:29 -0500, Heather McIntyre wrote: > I have a quick query regarding how you'd prefer to handle these changes. > Would you like me to implement some of the recommended modifications and > commit them (if possible), or would you prefer that I simply leave > comments so you can make the necessary adjustments? Both! :) Ideally you'll go over the individual emails for each patch that hasn't been committed yet and reply whether you agree or not with my observations. I might have misinterpreted the goal of a patch or set constraints that are unrealistic. So lets first make sure we agree on the specific issue we are going to fix. For the mechanics it depends a bit on being familiar with git and using it for using email to sent out patches. I like this: https://git-send-email.io/ But that is sometimes not the easiest to setup. In which case I would recommend creating an account on sourcehut=C2=A0https://meta.sr.ht/register and create a clone of elfutils there: https://git.sr.ht/~sourceware/elfutils You can push your commits on a branch on sr.ht and then you can use "Prepare a patchset" to sent emails to the list (or anyone else) from that server, so you don't need to setup git+email yourself locally. https://man.sr.ht/git.sr.ht/#sending-patches-upstream Cheers, Mark