public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: Milian Wolff <mail@milianw.de>
Cc: elfutils-devel@sourceware.org
Subject: Re: dwfl_attach_state alternative taking Ebl?
Date: Thu, 30 Mar 2017 10:57:00 -0000	[thread overview]
Message-ID: <1490871453.6461.169.camel@klomp.org> (raw)
In-Reply-To: <1662463.uA56NKcFP1@agathebauer>

On Wed, 2017-03-29 at 23:57 +0200, Milian Wolff wrote:
> On Mittwoch, 29. März 2017 21:48:08 CEST Mark Wielaard wrote:
> > Would it help your use case if there was a dwfl_init_state (Dwfl *dwfl,
> > int e_machine, unsigned char ei_class, unsigned char ei_data, ...)?
> 
> What magic values do I pass to e_machine, ei_class, ei_data?

That would be one of the EM e_machine architecture constants, ELFCLASS32
or ELFCLASS64 for ei_class and ELFDATA2LSB or ELFDATA2MSB for ei_data.
(e_machine could arguably be a GElf_Half).

> I guess the ebl  API that takes the Elf architecture or archicture
> name would be better.

I think we should extend the ebl_openbackend calls with a variant that
takes all three machine/class/data constants. If you look at the
machines table in libebl/eblopenbackend.c you see that given just the EM
architecture constant or (emulation) name without an Elf handle given we
cannot distinguish between e.g. ppc64 (EM_PPC64/ELFCLASS64/ELFDATA2MSB)
and ppc64le (EM_PPC64/ELFCLASS64/ELFDATA2LSB). You may obviously counter
that just means that table isn't complete. But then we have to document
(and maybe export?) the emulation names that people can rely on. Which
is why I was suggesting we rely on the machine/class/data triple to
uniquely identify the architecture. Maybe that is inconvenient though?

> > And what exactly is your use case? Maybe we can come up with a better
> > interface.
> 
> The use-case is parsing profiler data, e.g. in perfparser by Ulf / TQC. We 
> don't mess with Elf* anywhere, but need it to let dwfl_attach_state figure out 
> the target architecture. We do know the architecture already so this is a lot 
> of jumping through hoops, to find a fitting Elf* that can be used for dwfl 
> then...

OK. How do you know the Elf architecture in that case? How and by what
is it given? Is that an EM constant or some architecture string?

Cheers,

Mark

  reply	other threads:[~2017-03-30 10:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-29 14:50 Milian Wolff
2017-03-29 19:48 ` Mark Wielaard
2017-03-29 21:57   ` Milian Wolff
2017-03-30 10:57     ` Mark Wielaard [this message]
2017-03-30 11:14       ` Milian Wolff
2017-04-05 12:46         ` Mark Wielaard
2017-04-05 12:53           ` Ulf Hermann
2017-04-05 13:04           ` Milian Wolff
2017-04-11 12:10             ` Mark Wielaard
2017-04-11 12:28               ` Ulf Hermann
2017-04-19 19:50                 ` Mark Wielaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1490871453.6461.169.camel@klomp.org \
    --to=mark@klomp.org \
    --cc=elfutils-devel@sourceware.org \
    --cc=mail@milianw.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).