From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100079 invoked by alias); 2 May 2017 11:17:27 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 100060 invoked by uid 89); 2 May 2017 11:17:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=H*M:151 X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 02 May 2017 11:17:25 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 41BE430278C7; Tue, 2 May 2017 13:17:25 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 2FAB24000295; Tue, 2 May 2017 13:17:25 +0200 (CEST) Message-ID: <1493723844.31726.151.camel@klomp.org> Subject: Re: [PATCH] Make __attribute__ conditional in all installed headers From: Mark Wielaard To: Ulf Hermann Cc: elfutils-devel@sourceware.org Date: Tue, 02 May 2017 11:56:00 -0000 In-Reply-To: <86b22af7-30e4-c454-3b09-68499e03157e@qt.io> References: <86b22af7-30e4-c454-3b09-68499e03157e@qt.io> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.12.11 (3.12.11-22.el7) Mime-Version: 1.0 X-IsSubscribed: yes X-SW-Source: 2017-q2/txt/msg00131.txt.bz2 On Thu, 2017-04-20 at 15:55 +0200, Ulf Hermann wrote: > __attribute__ is a GNU extension. If we want to link against the > libraries using a different compiler, it needs to be disabled. It was > already disabled in libdw.h, and this patch extends this to the other > headers. We move the defines to libelf.h as that is included in all > the others. Looks like a nice cleanup in general. My only concern was that libelf.h is a "more" public header than libdw.h and so the macros could in theory clash with other code. But I couldn't find any other code that uses them except elfutils code itself. And if there was any then we already exported them through libdw.h anyway. It does add another explicit dependency between elfutils libdw and elfutils libelf, but given that libdw already does have some dependencies on elfutils libelf internals I don't think that matters. Applied to master. Thanks, Mark