From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7361 invoked by alias); 2 May 2017 11:20:43 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 7258 invoked by uid 89); 2 May 2017 11:20:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=Hx-languages-length:351, H*M:153 X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 02 May 2017 11:20:40 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id F1D7730132EE; Tue, 2 May 2017 13:20:40 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id DE6674000295; Tue, 2 May 2017 13:20:40 +0200 (CEST) Message-ID: <1493724040.31726.153.camel@klomp.org> Subject: Re: [PATCH] Use F_GETFD rather than F_GETFL to check validity of file descriptor From: Mark Wielaard To: Ulf Hermann Cc: elfutils-devel@sourceware.org Date: Tue, 02 May 2017 14:43:00 -0000 In-Reply-To: <046928f6-6f30-4b8f-3f46-b7497bb3327f@qt.io> References: <046928f6-6f30-4b8f-3f46-b7497bb3327f@qt.io> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.12.11 (3.12.11-22.el7) Mime-Version: 1.0 X-IsSubscribed: yes X-SW-Source: 2017-q2/txt/msg00132.txt.bz2 On Thu, 2017-04-20 at 15:58 +0200, Ulf Hermann wrote: > F_GETFD is both cheaper and easier to port, and otherwise has the same > effect here. At least for the specific case of checking for failure with errno =3D=3D EBADF it is identical. Applied to master. Thanks, Mark