From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124567 invoked by alias); 2 May 2017 14:43:52 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 124555 invoked by uid 89); 2 May 2017 14:43:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=16th X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 02 May 2017 14:43:50 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 251133001761; Tue, 2 May 2017 16:43:51 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id EAF514000295; Tue, 2 May 2017 16:43:50 +0200 (CEST) Message-ID: <1493736230.31726.174.camel@klomp.org> Subject: Re: [PATCH 5/5] Add frame pointer unwinding for aarch64 From: Mark Wielaard To: Ulf Hermann Cc: elfutils-devel@sourceware.org Date: Wed, 03 May 2017 08:46:00 -0000 In-Reply-To: <4c8f3f4f-aa4c-7202-0e66-665899caf2ff@qt.io> References: <1493124006.31726.33.camel@klomp.org> <1493124579-21017-1-git-send-email-mark@klomp.org> <1493124579-21017-5-git-send-email-mark@klomp.org> <1493125881.31726.44.camel@klomp.org> <3b0d6718-cf17-9ae1-b5f7-8c6413b8d3d2@qt.io> <1493217200.31726.59.camel@klomp.org> <14b0cd1d-5737-2c7a-3fab-f197011c7fc6@qt.io> <1493248187.31726.92.camel@klomp.org> <4c8f3f4f-aa4c-7202-0e66-665899caf2ff@qt.io> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.12.11 (3.12.11-22.el7) Mime-Version: 1.0 X-IsSubscribed: yes X-SW-Source: 2017-q2/txt/msg00135.txt.bz2 On Thu, 2017-04-27 at 10:31 +0200, Ulf Hermann wrote: > > Maybe something like the attached patch? >=20 > Well that's actually the original patch (as opposed to V2) with relaxed=20 > test conditions. You can write that a bit nicer by setting the new PC=20 > directly after retrieving LR and returning early if it doesn't work. See= =20 > "[PATCH 2/3] Add frame pointer unwinding as fallback on arm" from=20 > February 16th. That's the original algorithm; for aarch64 I just added a= =20 > few defines and included arm_unwind.c. OK, I made that cleanup and rebased the mjw/fp-unwind branch to master. All patches on that branch are now pushed so for 0.169 we should have a frame pointer unwinder backtrace fallback for at least x86_64, i686 and aarch64. Thanks for all your work and sorry this took a while to land. Cheers, Mark