From: Mark Wielaard <mark@klomp.org>
To: Ulf Hermann <ulf.hermann@qt.io>
Cc: elfutils-devel@sourceware.org
Subject: Re: [PATCH] Drop __BEGIN_DECLS and __END_DECLS from elf.h
Date: Fri, 05 May 2017 13:16:00 -0000 [thread overview]
Message-ID: <1493984303.31726.275.camel@klomp.org> (raw)
In-Reply-To: <253cf7c9-2244-2b79-ba80-e90a6214e57d@qt.io>
On Wed, 2017-05-03 at 18:03 +0200, Ulf Hermann wrote:
> We don't use those anywhere else and they are not guaranteed to be
> defined. Also, put the 'extern "C"' after the included headers.
Note that elf.h is somewhat special. We import it as-is from glibc and
like to not have divergence if at all possible. So could you try
submitting to glibc upstream first? (libc-alpha@sourceware.org)
They might say they expect your features.h to provide these macros.
But they might also just take the change as is. If not we'll figure
something out for elfutils.
Thanks,
Mark
prev parent reply other threads:[~2017-05-05 11:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-03 16:52 Ulf Hermann
2017-05-05 13:16 ` Mark Wielaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493984303.31726.275.camel@klomp.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=ulf.hermann@qt.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).