From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14346 invoked by alias); 5 May 2017 11:38:25 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 14099 invoked by uid 89); 5 May 2017 11:38:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=Hx-languages-length:628, H*F:U*mark, guaranteed X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 05 May 2017 11:38:23 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id B9C9E30007A4; Fri, 5 May 2017 13:38:23 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id A453F41AA36F; Fri, 5 May 2017 13:38:23 +0200 (CEST) Message-ID: <1493984303.31726.275.camel@klomp.org> Subject: Re: [PATCH] Drop __BEGIN_DECLS and __END_DECLS from elf.h From: Mark Wielaard To: Ulf Hermann Cc: elfutils-devel@sourceware.org Date: Fri, 05 May 2017 13:16:00 -0000 In-Reply-To: <253cf7c9-2244-2b79-ba80-e90a6214e57d@qt.io> References: <253cf7c9-2244-2b79-ba80-e90a6214e57d@qt.io> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.12.11 (3.12.11-22.el7) Mime-Version: 1.0 X-IsSubscribed: yes X-SW-Source: 2017-q2/txt/msg00191.txt.bz2 On Wed, 2017-05-03 at 18:03 +0200, Ulf Hermann wrote: > We don't use those anywhere else and they are not guaranteed to be > defined. Also, put the 'extern "C"' after the included headers. Note that elf.h is somewhat special. We import it as-is from glibc and like to not have divergence if at all possible. So could you try submitting to glibc upstream first? (libc-alpha@sourceware.org) They might say they expect your features.h to provide these macros. But they might also just take the change as is. If not we'll figure something out for elfutils. Thanks, Mark