From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107637 invoked by alias); 17 Jul 2017 16:41:52 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 107616 invoked by uid 89); 17 Jul 2017 16:41:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=affecting X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Jul 2017 16:41:50 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 2E2AC302758C; Mon, 17 Jul 2017 18:41:48 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 1496D40E39EF; Mon, 17 Jul 2017 18:41:48 +0200 (CEST) Message-ID: <1500309707.14595.379.camel@klomp.org> Subject: Re: [COMMITTED] backends: Swap sys/ptrace.h and asm/ptrace.h include order on s390. From: Mark Wielaard To: "Dmitry V. Levin" Cc: elfutils-devel@sourceware.org Date: Mon, 17 Jul 2017 16:41:00 -0000 In-Reply-To: <20170717162948.GA8679@altlinux.org> References: <1500306294-12809-1-git-send-email-mark@klomp.org> <20170717162948.GA8679@altlinux.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.12.11 (3.12.11-22.el7) Mime-Version: 1.0 X-IsSubscribed: yes X-SW-Source: 2017-q3/txt/msg00020.txt.bz2 On Mon, 2017-07-17 at 19:29 +0300, Dmitry V. Levin wrote: > On Mon, Jul 17, 2017 at 05:44:54PM +0200, Mark Wielaard wrote: > > glibc 2.26 changed the sys/ptrace.h header so that it cannot be included > > after asm/ptrace.h. We still need to include the kernel asm/ptrace.h for > > the ptrace_area definition. Including it after sys/ptrace.h works again= st > > both old and new glibc. >=20 > If it's a glibc regression, shouldn't it be fixed on glibc side before > 2.26 is out? I asked and it was done deliberately. See glibc 2.26 NEWS under Deprecated and removed features, and other changes affecting compatibility. For the functionality we needed it was always necessary to include the kernel asm/ptrace.h also (and it still is with 2.26) on s390. The only regression (for us) is that the order of the includes needs to be sys/ptrace.h first, then asm/ptrace.h. I double checked that the functionality needed still works (the run-backtrace-native.sh testcase works on both old s390 and s390x and new glibc s390x versions). Cheers, Mark