From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67175 invoked by alias); 21 Jul 2017 19:55:52 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 67139 invoked by uid 89); 21 Jul 2017 19:55:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY autolearn=ham version=3.3.2 spammy=Hx-languages-length:1655 X-Spam-Status: No, score=-25.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Jul 2017 19:55:49 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 572B1304D729; Fri, 21 Jul 2017 21:55:47 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 3237140E39EF; Fri, 21 Jul 2017 21:55:47 +0200 (CEST) Message-ID: <1500666946.14595.485.camel@klomp.org> Subject: Re: [PATCH] ppc64: Add HTM SPRs support to readelf From: Mark Wielaard To: Gustavo Romero Cc: elfutils-devel@sourceware.org Date: Fri, 21 Jul 2017 19:55:00 -0000 In-Reply-To: <1500587342-21923-1-git-send-email-gromero@linux.vnet.ibm.com> References: <1500587342-21923-1-git-send-email-gromero@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.12.11 (3.12.11-22.el7) Mime-Version: 1.0 X-IsSubscribed: yes X-SW-Source: 2017-q3/txt/msg00035.txt.bz2 On Thu, 2017-07-20 at 17:49 -0400, Gustavo Romero wrote: > Since POWER8, PowerPC 64 supports Hardware Transactional Memory, which has > three special purpose registers associated to it: tfhar, tfiar, and texas= r. > This commit add HTM SPRs set as known note type so it's possible to use > 'readelf --notes' to inspect the HTM SPRs in a coredump file generated in > such a machines. This patch looks perfect, thanks. One nitpick. > diff --git a/libelf/ChangeLog b/libelf/ChangeLog > index 594bec9..e5529e9 100644 > --- a/libelf/ChangeLog > +++ b/libelf/ChangeLog > @@ -1,3 +1,7 @@ > +2017-07-19 Gustavo Romero > + > + * elf.h: Add known type in notes segment descriptor for HTM SPRs. > + > 2017-04-20 Ulf Hermann >=20=20 > * libelfP.h: Don't include config.h. > diff --git a/libelf/elf.h b/libelf/elf.h > index b6112d9..fa35203 100644 > --- a/libelf/elf.h > +++ b/libelf/elf.h > @@ -763,6 +763,7 @@ typedef struct > #define NT_PPC_SPE 0x101 /* PowerPC SPE/EVR registers */ > #define NT_PPC_VSX 0x102 /* PowerPC VSX registers */ > #define NT_386_TLS 0x200 /* i386 TLS slots (struct user_desc) */ > +#define NT_PPC_TM_SPR 0x10c /* PowerPC HW Transactional Memory SPRs */ > #define NT_386_IOPERM 0x201 /* x86 io permission bitmap (1=3Ddeny) */ > #define NT_X86_XSTATE 0x202 /* x86 extended state using xsave */ > #define NT_S390_HIGH_GPRS 0x300 /* s390 upper register halves */ We normally keep elf.h in sync with glibc. Could you submit this elf.h change to libc-alpha@sourceware.org? Then we resync elf.h from glibc to pull in the new constants. Thanks, Mark