From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42297 invoked by alias); 27 Jul 2017 16:12:30 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 41992 invoked by uid 89); 27 Jul 2017 16:12:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=Hx-languages-length:432 X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Jul 2017 16:12:17 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id A1BCC30AE9FB; Thu, 27 Jul 2017 18:12:13 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 96365413CE20; Thu, 27 Jul 2017 18:12:13 +0200 (CEST) Message-ID: <1501171933.3741.14.camel@klomp.org> Subject: Re: [PATCH] libdwfl: Move nested functions in parse_opt to file scope. From: Mark Wielaard To: Yunlian Jiang Cc: elfutils-devel@sourceware.org Date: Thu, 27 Jul 2017 16:12:00 -0000 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.12.11 (3.12.11-22.el7) Mime-Version: 1.0 X-IsSubscribed: yes X-SW-Source: 2017-q3/txt/msg00057.txt.bz2 On Thu, 2017-07-27 at 08:42 -0700, Yunlian Jiang via elfutils-devel wrote: > * Move nested function 'failure' to file scope to compile with clang. > * Move nested function 'fail' to file scope to compile with clang. The patch seems fine but doesn't apply because of whitespace issues (looks like tab versus space issues?) Could you sent again. Thanks, Mark