From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50041 invoked by alias); 19 Sep 2017 14:52:37 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 49497 invoked by uid 89); 19 Sep 2017 14:52:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY autolearn=ham version=3.3.2 spammy=H*Ad:D*io X-Spam-Status: No, score=-25.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 19 Sep 2017 14:52:35 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id A3129302BB21; Tue, 19 Sep 2017 16:52:33 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 94FF8422D6FE; Tue, 19 Sep 2017 16:52:33 +0200 (CEST) Message-ID: <1505832753.16945.52.camel@klomp.org> Subject: Re: [PATCH 1/2] Initialize type_offset of fake_cu From: Mark Wielaard To: Ulf Hermann , elfutils-devel@sourceware.org Date: Tue, 19 Sep 2017 14:52:00 -0000 In-Reply-To: <2f0433b3-f16c-41f4-bfad-2e3d004cea29@qt.io> References: <47e9193b-bfb3-a652-de71-ebea8c566c4b@qt.io> <2f0433b3-f16c-41f4-bfad-2e3d004cea29@qt.io> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 X-IsSubscribed: yes X-SW-Source: 2017-q3/txt/msg00118.txt.bz2 On Wed, 2017-09-06 at 12:38 +0200, Ulf Hermann wrote: > On 05/09/2017 06:28 PM, Ulf Hermann wrote: > > Signed-off-by: Ulf Hermann > > --- > > =C2=A0libdw/ChangeLog=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0| 4 ++++ > > =C2=A0libdw/dwarf_getmacros.c | 1 + > > =C2=A02 files changed, 5 insertions(+) > > [...] >=20 > It seems we missed this one, but it fixes a bug. Can we apply it? > PATCH 2/2 is not actually related. I assume you mean this patch: > diff --git a/libdw/dwarf_getmacros.c b/libdw/dwarf_getmacros.c > index eb50508..9e2a4a1 100644 > --- a/libdw/dwarf_getmacros.c > +++ b/libdw/dwarf_getmacros.c > @@ -361,6 +361,7 @@ read_macros (Dwarf *dbg, int sec_index, > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0.offset_size =3D table->i= s_64bit ? 8 : 4, > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0.startp =3D (void *) star= tp + offset, > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0.endp =3D (void *) endp, > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0.type_offset =3D 0, > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0}; > =C2=A0 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Dwarf_Attribute *attributes; That really shouldn't be necessary. In a named struct field initializer omitted elements are initialized to zero. Are you sure it fixes a real bug? In that case it might be a compiler bug instead (which we would want to work around, but then lets make sure to report it and add a comment). Cheers, Mark