From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48791 invoked by alias); 4 Oct 2017 19:02:00 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 48706 invoked by uid 89); 4 Oct 2017 19:02:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,MIME_BASE64_BLANKS autolearn=ham version=3.3.2 spammy=williams, Williams, HTo:U*bill, H*Ad:U*bill X-Spam-Status: No, score=-25.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,MIME_BASE64_BLANKS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Oct 2017 19:01:58 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 79D32302BB23; Wed, 4 Oct 2017 21:01:56 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 6A737413F1DE; Wed, 4 Oct 2017 21:01:56 +0200 (CEST) Message-ID: <1507143716.9961.27.camel@klomp.org> Subject: Re: missing #include in libdw.h? From: Mark Wielaard To: Bill Williams , "elfutils-devel@sourceware.org" Date: Wed, 04 Oct 2017 19:02:00 -0000 In-Reply-To: References: Content-Type: multipart/mixed; boundary="=-FH8T7UCWU9DWIRP4wxXi" X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 X-IsSubscribed: yes X-SW-Source: 2017-q4/txt/msg00007.txt.bz2 --=-FH8T7UCWU9DWIRP4wxXi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-length: 715 On Tue, 2017-10-03 at 19:30 +0000, Bill Williams wrote: > libdw.h uses the DW_CIE_ID_64 define from dwarf.h in a macro > definition, but does not itself include dwarf.h. This makes the > libdw.h header not self-contained if and only if your code uses the > dwarf_cfi_cie_p macro. Is this behavior by design, or a bug? I don't think this is by design. It seems a bug nobody noticed before because people often do include dwarf.h also. But nothing else explicitly needs the dwarf.h constants. It would probably not break anything to explicitly include dwarf.h in libdw.h, but it seems better to just define this constant explicitly in libdw.h as the attached patch does. Does that make sense to you? Thanks, Mark= --=-FH8T7UCWU9DWIRP4wxXi Content-Disposition: inline; filename*0=0001-libdw-Define-LIBDW_CIE_ID-and-use-it-in-dwarf_cfi_ci.pat; filename*1=ch Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-libdw-Define-LIBDW_CIE_ID-and-use-it-in-dwarf_cfi_ci.patch"; charset="UTF-8" Content-length: 2009 RnJvbSAyNTFiYjFjOGM0YTBhNTIzNzkxODc0YzE0ODI2YzM5MTE3M2JjZTRj IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJrIFdpZWxhYXJk IDxtYXJrQGtsb21wLm9yZz4KRGF0ZTogVHVlLCAzIE9jdCAyMDE3IDIzOjA4 OjAxICswMjAwClN1YmplY3Q6IFtQQVRDSF0gbGliZHc6IERlZmluZSBMSUJE V19DSUVfSUQgYW5kIHVzZSBpdCBpbiBkd2FyZl9jZmlfY2llX3AuCgpkd2Fy Zl9jZmlfY2llX3AgdXNlZCBEV19DSUVfSURfNjQgZnJvbSBkd2FyZi5oIHdo aWNoIG1lYW50IHlvdSBoYWQKdG8gaW5jbHVkZSBkd2FyZi5oIGp1c3QgdG8g dXNlIHRoZSBkd2FyZl9jZmlfY2llX3AgbWFjcm9zLiBKdXN0IGRlZmluZQp0 aGUgY29uc3RhbnQgYXMgTElCRFdfQ0lFX0lEIGluIGxpYmR3LmggdG8ga2Vl cCBpdCBpbmRlcGVuZGVudC4KClNpZ25lZC1vZmYtYnk6IE1hcmsgV2llbGFh cmQgPG1hcmtAa2xvbXAub3JnPgotLS0KIGxpYmR3L0NoYW5nZUxvZyB8IDQg KysrKwogbGliZHcvbGliZHcuaCAgIHwgNCArKystCiAyIGZpbGVzIGNoYW5n ZWQsIDcgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdp dCBhL2xpYmR3L0NoYW5nZUxvZyBiL2xpYmR3L0NoYW5nZUxvZwppbmRleCA5 NGU5YzlhLi5lNmU3ZjNiIDEwMDY0NAotLS0gYS9saWJkdy9DaGFuZ2VMb2cK KysrIGIvbGliZHcvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsNyBAQAorMjAxNy0x MC0wMyAgTWFyayBXaWVsYWFyZCAgPG1hcmtAa2xvbXAub3JnPgorCisJKiBs aWJkdy5oOiBEZWZpbmUgTElCRFdfQ0lFX0lEIGFuZCB1c2UgaXQgaW4gZHdh cmZfY2ZpX2NpZV9wLgorCiAyMDE3LTA4LTE4ICBVbGYgSGVybWFubiAgPHVs Zi5oZXJtYW5uQHF0LmlvPgogCiAJKiBtZW1vcnktYWNjZXNzLmg6IFVzZSBh dHRyaWJ1dGVfcGFja2VkLgpkaWZmIC0tZ2l0IGEvbGliZHcvbGliZHcuaCBi L2xpYmR3L2xpYmR3LmgKaW5kZXggNjNhMzhmZi4uZTQyYzA4NyAxMDA2NDQK LS0tIGEvbGliZHcvbGliZHcuaAorKysgYi9saWJkdy9saWJkdy5oCkBAIC0y MTEsNyArMjExLDkgQEAgdHlwZWRlZiB1bmlvbgogICBEd2FyZl9GREUgZmRl OwogfSBEd2FyZl9DRklfRW50cnk7CiAKLSNkZWZpbmUgZHdhcmZfY2ZpX2Np ZV9wKGVudHJ5KQkoKGVudHJ5KS0+Y2llLkNJRV9pZCA9PSBEV19DSUVfSURf NjQpCisvKiBTYW1lIGFzIERXX0NJRV9JRF82NCBmcm9tIGR3YXJmLmggdG8g a2VlcCBsaWJkdy5oIGluZGVwZW5kZW50LiAgKi8KKyNkZWZpbmUgTElCRFdf Q0lFX0lEIDB4ZmZmZmZmZmZmZmZmZmZmZlVMTAorI2RlZmluZSBkd2FyZl9j ZmlfY2llX3AoZW50cnkpCSgoZW50cnkpLT5jaWUuQ0lFX2lkID09IExJQkRX X0NJRV9JRCkKIAogLyogT3BhcXVlIHR5cGUgcmVwcmVzZW50aW5nIGEgZnJh bWUgc3RhdGUgZGVzY3JpYmVkIGJ5IENGSS4gICovCiB0eXBlZGVmIHN0cnVj dCBEd2FyZl9GcmFtZV9zIER3YXJmX0ZyYW1lOwotLSAKMS44LjMuMQoK --=-FH8T7UCWU9DWIRP4wxXi--