From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130294 invoked by alias); 16 Oct 2017 14:21:51 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 129819 invoked by uid 89); 16 Oct 2017 14:21:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=Hx-languages-length:507 X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Oct 2017 14:21:48 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 642EE30278BF for ; Mon, 16 Oct 2017 16:21:46 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id F1182419BBAC; Mon, 16 Oct 2017 16:21:45 +0200 (CEST) Message-ID: <1508163705.3073.2.camel@klomp.org> Subject: Re: [PATCH] lib: sha1, md5, use memmove to move bytes inside buffer, not memcpy. From: Mark Wielaard To: elfutils-devel@sourceware.org Date: Mon, 16 Oct 2017 14:21:00 -0000 In-Reply-To: <1508151613-29280-1-git-send-email-mark@klomp.org> References: <1508151613-29280-1-git-send-email-mark@klomp.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2017-q4/txt/msg00025.txt.bz2 On Mon, 2017-10-16 at 13:00 +0200, Mark Wielaard wrote: > At the end of {sha1,md5}_process_bytes we move the contents of > ctx->buffer up to the start of the buffer. Since this means the > source and destination overlap we should use memmove, not memcpy. I am retracting this patch since I noticed nothing was actually using this code except for one testcase. I'll post a patch removing the implementation and the testcase.