From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112991 invoked by alias); 26 Oct 2017 14:28:31 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 112857 invoked by uid 89); 26 Oct 2017 14:28:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY autolearn=ham version=3.3.2 spammy=H*F:U*mark X-Spam-Status: No, score=-25.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 26 Oct 2017 14:28:27 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id AE67731F8C52 for ; Thu, 26 Oct 2017 16:28:24 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 69EB7413CD4E; Thu, 26 Oct 2017 16:28:24 +0200 (CEST) Message-ID: <1509028104.10879.18.camel@klomp.org> Subject: Re: [PATCH] backends: Ignore GCC8 -Wpacked-not-aligned for m68k_corenote.c. From: Mark Wielaard To: elfutils-devel@sourceware.org Date: Thu, 26 Oct 2017 14:28:00 -0000 In-Reply-To: <1508848549-24746-1-git-send-email-mark@klomp.org> References: <1508848549-24746-1-git-send-email-mark@klomp.org> Content-Type: multipart/mixed; boundary="=-8VvNL03Xj+nTFBX3hF0c" X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2017-q4/txt/msg00030.txt.bz2 --=-8VvNL03Xj+nTFBX3hF0c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-length: 1248 On Tue, 2017-10-24 at 14:35 +0200, Mark Wielaard wrote: > The GCC8 -Wpacked-not-aligned warns if a structure field with explicit > padding in a packed structure will be misaligned. m68k prstatus core > notes are described by a packed structure which has such aligned structure > fields. Well, that worked, but only because of two typos canceling each other out... > +# m68k prstatus core notes are described by a packed structure > +# which has not naturally aligned fields. Since we don't access > +# these fields directly, but take their offset to be used later > +# to extract the data through elfxx_xlatetom/memmove, this isn't > +# an issue. > +m68k_corenote_Wpacked_not_aligned =3D yes Missing no_ ... > +++ b/config/eu.am > @@ -74,6 +74,7 @@ AM_CFLAGS =3D -std=3Dgnu99 -Wall -Wshadow -Wformat=3D2 \ > > =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0$(if $($(*F)_no_Werror),,-Werror) \ > > =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0$(if $($(*F)_no_Wunused),,-Wunused -Wext= ra) \ > > =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0$(if $($(*F)_no_Wstack_usage),,$(STACK_U= SAGE_WARNING)) \ > > + =C2=A0=C2=A0=C2=A0=C2=A0$(if $($(*F)_no_Wpacked_not_aligned),,-Wno-pa= cked-not-aligned) \ Double ,, causing everything to get -Wno-packaged-not-aligned. Oops. Fixed patch attached. --=-8VvNL03Xj+nTFBX3hF0c Content-Description: Content-Disposition: inline; filename*0=0001-backends-Ignore-GCC8-Wpacked-not-aligned-for-m68k_co.pat; filename*1=ch Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-backends-Ignore-GCC8-Wpacked-not-aligned-for-m68k_co.patch"; charset="UTF-8" Content-length: 3518 RnJvbSBhYjZiMzdhYzMyZGRmMmYyZjExZjgwMGE3NzAxNzA4MTRmNWNiYjhi IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJrIFdpZWxhYXJk IDxtYXJrQGtsb21wLm9yZz4KRGF0ZTogVHVlLCAyNCBPY3QgMjAxNyAxNDoy MzozMCArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIGJhY2tlbmRzOiBJZ25vcmUg R0NDOCAtV3BhY2tlZC1ub3QtYWxpZ25lZCBmb3IKIG02OGtfY29yZW5vdGUu Yy4KClRoZSBHQ0M4IC1XcGFja2VkLW5vdC1hbGlnbmVkIHdhcm5zIGlmIGEg c3RydWN0dXJlIGZpZWxkIHdpdGggZXhwbGljaXQKcGFkZGluZyBpbiBhIHBh Y2tlZCBzdHJ1Y3R1cmUgd2lsbCBiZSBtaXNhbGlnbmVkLiBtNjhrIHByc3Rh dHVzIGNvcmUKbm90ZXMgYXJlIGRlc2NyaWJlZCBieSBhIHBhY2tlZCBzdHJ1 Y3R1cmUgd2hpY2ggaGFzIHN1Y2ggYWxpZ25lZCBzdHJ1Y3R1cmUKZmllbGRz LgoKU2lnbmVkLW9mZi1ieTogTWFyayBXaWVsYWFyZCA8bWFya0BrbG9tcC5v cmc+Ci0tLQogYmFja2VuZHMvQ2hhbmdlTG9nICAgfCA0ICsrKysKIGJhY2tl bmRzL01ha2VmaWxlLmFtIHwgNyArKysrKysrCiBjb25maWcvQ2hhbmdlTG9n ICAgICB8IDQgKysrKwogY29uZmlnL2V1LmFtICAgICAgICAgfCAxICsKIDQg ZmlsZXMgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBh L2JhY2tlbmRzL0NoYW5nZUxvZyBiL2JhY2tlbmRzL0NoYW5nZUxvZwppbmRl eCA4YzNmNDJjLi4xOTBhZTk2IDEwMDY0NAotLS0gYS9iYWNrZW5kcy9DaGFu Z2VMb2cKKysrIGIvYmFja2VuZHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsNyBA QAorMjAxNy0xMC0yNCAgTWFyayBXaWVsYWFyZCAgPG1hcmtAa2xvbXAub3Jn PgorCisJKiBNYWtlZmlsZS5hbSAobTY4a19jb3Jlbm90ZV9ub19XcGFja2Vk X25vdF9hbGlnbmVkKTogTmV3IHZhcmlhYmxlLgorCiAyMDE3LTA4LTE4ICBV bGYgSGVybWFubiA8dWxmLmhlcm1hbm5AcXQuaW8+CiAKIAkqIGxpbnV4LWNv cmUtbm90ZS5jOiBVc2UgYXR0cmlidXRlX3BhY2tlZC4KZGlmZiAtLWdpdCBh L2JhY2tlbmRzL01ha2VmaWxlLmFtIGIvYmFja2VuZHMvTWFrZWZpbGUuYW0K aW5kZXggMGZkZTBjYi4uMmM2MmFkZCAxMDA2NDQKLS0tIGEvYmFja2VuZHMv TWFrZWZpbGUuYW0KKysrIGIvYmFja2VuZHMvTWFrZWZpbGUuYW0KQEAgLTEx OSw2ICsxMTksMTMgQEAgbTY4a19TUkNTID0gbTY4a19pbml0LmMgbTY4a19z eW1ib2wuYyBtNjhrX3JlZ3MuYyBcCiBsaWJlYmxfbTY4a19waWNfYV9TT1VS Q0VTID0gJChtNjhrX1NSQ1MpCiBhbV9saWJlYmxfbTY4a19waWNfYV9PQkpF Q1RTID0gJChtNjhrX1NSQ1M6LmM9Lm9zKQogCisjIG02OGsgcHJzdGF0dXMg Y29yZSBub3RlcyBhcmUgZGVzY3JpYmVkIGJ5IGEgcGFja2VkIHN0cnVjdHVy ZQorIyB3aGljaCBoYXMgbm90IG5hdHVyYWxseSBhbGlnbmVkIGZpZWxkcy4g U2luY2Ugd2UgZG9uJ3QgYWNjZXNzCisjIHRoZXNlIGZpZWxkcyBkaXJlY3Rs eSwgYnV0IHRha2UgdGhlaXIgb2Zmc2V0IHRvIGJlIHVzZWQgbGF0ZXIKKyMg dG8gZXh0cmFjdCB0aGUgZGF0YSB0aHJvdWdoIGVsZnh4X3hsYXRldG9tL21l bW1vdmUsIHRoaXMgaXNuJ3QKKyMgYW4gaXNzdWUuCittNjhrX2NvcmVub3Rl X25vX1dwYWNrZWRfbm90X2FsaWduZWQgPSB5ZXMKKwogYnBmX1NSQ1MgPSBi cGZfaW5pdC5jIGJwZl9yZWdzLmMKIGNwdV9icGYgPSAuLi9saWJjcHUvbGli Y3B1X2JwZi5hCiBsaWJlYmxfYnBmX3BpY19hX1NPVVJDRVMgPSAkKGJwZl9T UkNTKQpkaWZmIC0tZ2l0IGEvY29uZmlnL0NoYW5nZUxvZyBiL2NvbmZpZy9D aGFuZ2VMb2cKaW5kZXggMWVkM2M0YS4uZGUwZDg5MCAxMDA2NDQKLS0tIGEv Y29uZmlnL0NoYW5nZUxvZworKysgYi9jb25maWcvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsNyBAQAorMjAxNy0xMC0yNCAgTWFyayBXaWVsYWFyZCAgPG1hcmtA a2xvbXAub3JnPgorCisJKiBldS5hbSAoQU1fQ0ZMQUdTKTogSGFuZGxlIC1X bm8tcGFja2VkLW5vdC1hbGlnbmVkLgorCiAyMDE3LTA0LTI3ICBVbGYgSGVy bWFubiAgPHVsZi5oZXJtYW5uQHF0LmlvPgogCiAJKiBldS5hbTogVXNlIGZw aWNfQ0ZMQUdTLgpkaWZmIC0tZ2l0IGEvY29uZmlnL2V1LmFtIGIvY29uZmln L2V1LmFtCmluZGV4IDc5NmYzODguLjA1YzI3ZjAgMTAwNjQ0Ci0tLSBhL2Nv bmZpZy9ldS5hbQorKysgYi9jb25maWcvZXUuYW0KQEAgLTc0LDYgKzc0LDcg QEAgQU1fQ0ZMQUdTID0gLXN0ZD1nbnU5OSAtV2FsbCAtV3NoYWRvdyAtV2Zv cm1hdD0yIFwKIAkgICAgJChpZiAkKCQoKkYpX25vX1dlcnJvciksLC1XZXJy b3IpIFwKIAkgICAgJChpZiAkKCQoKkYpX25vX1d1bnVzZWQpLCwtV3VudXNl ZCAtV2V4dHJhKSBcCiAJICAgICQoaWYgJCgkKCpGKV9ub19Xc3RhY2tfdXNh Z2UpLCwkKFNUQUNLX1VTQUdFX1dBUk5JTkcpKSBcCisJICAgICQoaWYgJCgk KCpGKV9ub19XcGFja2VkX25vdF9hbGlnbmVkKSwtV25vLXBhY2tlZC1ub3Qt YWxpZ25lZCwpIFwKIAkgICAgJCgkKCpGKV9DRkxBR1MpCiAKIENPTVBJTEUu b3MgPSAkKGZpbHRlci1vdXQgLWZwcm9maWxlLWFyY3MgLWZ0ZXN0LWNvdmVy YWdlLCAkKENPTVBJTEUpKQotLSAKMS44LjMuMQoK --=-8VvNL03Xj+nTFBX3hF0c--