From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22276 invoked by alias); 10 Nov 2017 15:38:32 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 21910 invoked by uid 89); 10 Nov 2017 15:38:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=UD:php X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 Nov 2017 15:38:31 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 617AD3000707 for ; Fri, 10 Nov 2017 16:38:29 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 5B55140216AE; Fri, 10 Nov 2017 16:38:29 +0100 (CET) Message-ID: <1510328309.10879.90.camel@klomp.org> Subject: Re: [PATCH 2/3] libdw: Update acceptable forms and attributes for dwarf_getlocation. From: Mark Wielaard To: elfutils-devel@sourceware.org Date: Fri, 10 Nov 2017 15:38:00 -0000 In-Reply-To: <1509838266-10337-2-git-send-email-mark@klomp.org> References: <1509838266-10337-1-git-send-email-mark@klomp.org> <1509838266-10337-2-git-send-email-mark@klomp.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2017-q4/txt/msg00040.txt.bz2 On Sun, 2017-11-05 at 00:31 +0100, Mark Wielaard wrote: > dwarf_getlocation has to know which attributes can contain a DWARF > expression or location list because the form alone might be ambiguous. >=20 > Since DWARF4 there is DW_FORM_exprloc so always accept that. But for older > DWARF or location lists we cannot just check for DW_FORM_sec_offset since > that could be a reference to diffent kinds of sections (based on attribut= e). >=20 > Update the attribute list based on the latest DWARF5 encodings table. > Note that DW_AT_call_origin wasn't added because that seems to be a > typo in the DWARF5 spec. http://dwarfstd.org/ShowIssue.php?issue=3D171103= .1 Pushed to master.