From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62206 invoked by alias); 16 Nov 2017 14:31:23 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 62191 invoked by uid 89); 16 Nov 2017 14:31:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,KB_WAM_FROM_NAME_SINGLEWORD autolearn=no version=3.3.2 spammy=Hx-languages-length:552 X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,KB_WAM_FROM_NAME_SINGLEWORD autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 Nov 2017 14:31:21 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 50B85304D562; Thu, 16 Nov 2017 15:31:19 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 01C654000ABE; Thu, 16 Nov 2017 15:31:18 +0100 (CET) Message-ID: <1510842678.6966.33.camel@klomp.org> Subject: Re: [PATCH] readelf: Print DIE offset in attribute reading error messages. From: Mark Wielaard To: elfutils-devel@sourceware.org Cc: Tom Tromey , Dodji Seketeli Date: Thu, 16 Nov 2017 14:31:00 -0000 In-Reply-To: <1507042757-27353-1-git-send-email-mark@klomp.org> References: <1507042757-27353-1-git-send-email-mark@klomp.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2017-q4/txt/msg00049.txt.bz2 On Tue, 2017-10-03 at 16:59 +0200, Mark Wielaard wrote: > When processing large files it is useful to know the DIE offset if > printing of attributes fails (especially when redirecting the output). > With this change the error message looks like: >=20 > =C2=A0 eu-readelf: DIE [2aeb8ef1] cannot get attribute value: invalid DWA= RF Got another report about a large debug file where this improved error message would have been really handy. So I pushed it to master now. Cheers, Mark