From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1468 invoked by alias); 22 Nov 2017 11:36:53 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 1457 invoked by uid 89); 22 Nov 2017 11:36:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,KB_WAM_FROM_NAME_SINGLEWORD autolearn=no version=3.3.2 spammy=welcome!, atm X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,KB_WAM_FROM_NAME_SINGLEWORD autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 22 Nov 2017 11:36:51 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 7EEAF302BB1E; Wed, 22 Nov 2017 12:36:49 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 3DCB9424DD7D; Wed, 22 Nov 2017 12:36:49 +0100 (CET) Message-ID: <1511350609.3112.20.camel@klomp.org> Subject: Re: [PATCH] readelf: Print DIE offset in attribute reading error messages. From: Mark Wielaard To: Tom Tromey Cc: elfutils-devel@sourceware.org, Dodji Seketeli Date: Wed, 22 Nov 2017 11:36:00 -0000 In-Reply-To: <87bmjvxwwo.fsf@tromey.com> References: <1507042757-27353-1-git-send-email-mark@klomp.org> <1510842678.6966.33.camel@klomp.org> <1511259709.3112.12.camel@klomp.org> <87bmjvxwwo.fsf@tromey.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2017-q4/txt/msg00068.txt.bz2 On Tue, 2017-11-21 at 12:19 -0700, Tom Tromey wrote: > > > > > > "Mark" =3D=3D Mark Wielaard writes: >=20 > Mark> This has been really useful to debug some DWARF format issues, but = it > Mark> could be even more useful. Since we know the attribute name and form > Mark> (or we would have generated an error earlier) add those to the error > Mark> message too. >=20 > Thanks for doing this. >=20 > Does dwarflint also report the error that prompted this? No, because I am actually testing my DWARF5 work and dwarflint doesn't support DWARF5 yet. (Also dwarflint doesn't build with the GCC8 trunk branch which I am using atm.) But also yes, in my tests I corrupted a DWARF4 .debug_ranges section so it couldn't be read and then dwarflint will yell and scream about attributes that references it. But also no, because after that it seems to go into a loop and never finishes... This might just be it finding too many issues with the missing ranges. It does suppress warnings after finding too many duplicates, and I haven't had the patience to let it finish. > I tried dwarflint on my file, but there was a lot of output and I never > did track down the precise problem, so I wasn't sure... Yeah, dwarflint seems hyper sensitive :) Patches welcome! Cheers, Mark