From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64595 invoked by alias); 24 Nov 2017 12:42:02 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 64579 invoked by uid 89); 24 Nov 2017 12:42:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,KB_WAM_FROM_NAME_SINGLEWORD autolearn=no version=3.3.2 spammy=Hx-languages-length:621 X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,KB_WAM_FROM_NAME_SINGLEWORD autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 24 Nov 2017 12:42:00 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 46B9F302BB38 for ; Fri, 24 Nov 2017 13:41:58 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 00057413CD0D; Fri, 24 Nov 2017 13:41:57 +0100 (CET) Message-ID: <1511527317.3112.30.camel@klomp.org> Subject: Re: [PATCH] libdwfl: Don't dereference possibly unaligned auxv entry pointer from core. From: Mark Wielaard To: elfutils-devel@sourceware.org Date: Fri, 24 Nov 2017 12:42:00 -0000 In-Reply-To: <1511183725-31739-1-git-send-email-mark@klomp.org> References: <1511183725-31739-1-git-send-email-mark@klomp.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2017-q4/txt/msg00072.txt.bz2 On Mon, 2017-11-20 at 14:15 +0100, Mark Wielaard wrote: > The notes in a core file that contain the auxv entries might not be > naturally aligned. The code already tried to account for that, but > the GCC 8 undefined behaviour sanitizer found we were till dereferencing > the actual auxv entry pointer directly. Fix this by calculating all point= ers > by hand and not use an array of auxv entries trick. >=20 > This makes make distcheck (which enables sanitize-undefined by default) > pass again using GCC8. Pushed this to master now.