From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10063 invoked by alias); 11 Dec 2017 23:13:19 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 10052 invoked by uid 89); 11 Dec 2017 23:13:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=pkgconfig, pkg-config X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 11 Dec 2017 23:13:17 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id A782B32B90FB; Tue, 12 Dec 2017 00:13:14 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 5DBD7400B8D4; Tue, 12 Dec 2017 00:13:14 +0100 (CET) Message-ID: <1513033994.15696.50.camel@klomp.org> Subject: Re: [PATCH] config: Add pkgincludedir to Cflags From: Mark Wielaard To: Namhyung Kim , elfutils-devel@sourceware.org Date: Mon, 11 Dec 2017 23:13:00 -0000 In-Reply-To: <20171208061738.25974-1-namhyung@gmail.com> References: <20171208061738.25974-1-namhyung@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2017-q4/txt/msg00101.txt.bz2 On Fri, 2017-12-08 at 15:17 +0900, Namhyung Kim wrote: > The libelf and libdw uses pkginclude_HEADERS but the pkg-config file > misses to have it the Cflags.=C2=A0=C2=A0This was a problem for libdw use= rs since > it gave nothing to include, but one needs to add /usr/include/elfutils > directory to use the libdw.h header file. I this really an issue? libelf has two public headers which are placed in the includedir and so should be simply included as #include and #include . libdw does indeed put its headers in includdir/elfutils, but as far as I know everybody includes them using that subdir, so #include and #include , etc. Wouldn't this change how people include the headers? Do we want to change it? Thanks, Mark