From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122019 invoked by alias); 12 Dec 2017 09:50:33 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 122006 invoked by uid 89); 12 Dec 2017 09:50:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=Hx-languages-length:599 X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Dec 2017 09:50:31 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 85A3632B90EF; Tue, 12 Dec 2017 10:50:29 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 151864000ABF; Tue, 12 Dec 2017 10:50:29 +0100 (CET) Message-ID: <1513072228.15696.54.camel@klomp.org> Subject: Re: [PATCH] Fix 22546: dwarf_aggregate_size() works with multi-dimensional arrays From: Mark Wielaard To: Dima Kogan , elfutils-devel@sourceware.org Date: Tue, 12 Dec 2017 09:50:00 -0000 In-Reply-To: <87r2s04hej.fsf@secretsauce.net> References: <87r2s04hej.fsf@secretsauce.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2017-q4/txt/msg00105.txt.bz2 On Mon, 2017-12-11 at 21:57 -0800, Dima Kogan wrote: > If we have a multidimensional array of dimensions (a,b,c) the number of e= lements > should be a*b*c, but prior to this patch dwarf_aggregate_size() would rep= ort > a+b+c instead. >=20 > This patch fixes the bug and adds a test that demonstrates the bug (the t= est > fails without the functional part of this patch). >=20 > Fixes: https://sourceware.org/bugzilla/show_bug.cgi?id=3D22546 Thanks. As said in the bug report, this looks good. Pushed to master. Cheers, Mark