From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99272 invoked by alias); 10 Feb 2018 12:39:51 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 99117 invoked by uid 89); 10 Feb 2018 12:39:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=Really X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 10 Feb 2018 12:39:49 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 07FAA310B6E5; Sat, 10 Feb 2018 13:39:46 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id BA9FF413CD0D; Sat, 10 Feb 2018 13:39:46 +0100 (CET) Message-ID: <1518266386.3657.32.camel@klomp.org> Subject: ChangeLog entries (Was: [PATCH v3] Use fallthrough attribute) From: Mark Wielaard To: "Frank Ch. Eigler" Cc: elfutils-devel@sourceware.org Date: Sat, 10 Feb 2018 12:39:00 -0000 In-Reply-To: <20180210033631.GM24815@redhat.com> References: <20180208233010.11395-1-JPEWhacker@gmail.com> <20180209162718.5905-1-JPEWhacker@gmail.com> <20180210022643.GD3320@wildebeest.org> <20180210033631.GM24815@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2018-q1/txt/msg00032.txt.bz2 On Fri, 2018-02-09 at 22:36 -0500, Frank Ch. Eigler wrote: > On Sat, Feb 10, 2018 at 03:26:43AM +0100, Mark Wielaard wrote: >=20 > > I added ChangeLog entries and pushed it to master. >=20 > What's a ChangeLog entry?=C2=A0=C2=A0:-) Yeah, yeah, I know. I am the last one to care. Really, it helps me review code (even my own - actually writing them makes me happy - o, right I did that!). If only to know a change is really intended to be there. To me the problem with dropping them is that there is no description anymore what changed. The commit message normally describes why something changed, not how. You of course have the diff to see what changed, but not in a summary form. And I really like to have a summary to cross check that what changed was intended to change. For people that don't like them, what exactly is it about them that you don't like? And what would you suggest as replacement? Thanks, Mark