From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29302 invoked by alias); 21 Feb 2018 15:36:27 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 29289 invoked by uid 89); 21 Feb 2018 15:36:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy= X-Spam-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Feb 2018 15:36:24 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 02676307C579; Wed, 21 Feb 2018 16:36:21 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id AB14141331A2; Wed, 21 Feb 2018 16:36:21 +0100 (CET) From: Mark Wielaard To: elfutils-devel@sourceware.org Cc: Nick Clifton , Mark Wielaard Subject: [PATCH] libebl: Allow SHT_NOTE as relocation target type. Date: Wed, 21 Feb 2018 15:36:00 -0000 Message-Id: <1519227364-17006-1-git-send-email-mark@klomp.org> X-Mailer: git-send-email 1.8.3.1 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2018-q1/txt/msg00043.txt.bz2 eu-elflint uses ebl_check_reloc_target_type to determine whether a section is a valid relocation target. In Fedora rawhide there are new ELF notes (annobin) which have relocations against them in ET_REL files. eu-elflint currently flags these as invalid. It looks like that is not correct. I cannot find any reason an SHT_NOTE section cannot have relocations against it. So this patch allows them. Signed-off-by: Mark Wielaard --- libebl/ChangeLog | 5 +++++ libebl/eblcheckreloctargettype.c | 1 + 2 files changed, 6 insertions(+) diff --git a/libebl/ChangeLog b/libebl/ChangeLog index 3ecd732..de325ab 100644 --- a/libebl/ChangeLog +++ b/libebl/ChangeLog @@ -1,3 +1,8 @@ +2018-02-21 Mark Wielaard + + * eblcheckreloctargettype.c (ebl_check_reloc_target_type): Accept + SHT_NOTE. + 2018-02-09 Joshua Watt * eblobjnote.c (ebl_object_note): Use FALLTHROUGH macro instead of diff --git a/libebl/eblcheckreloctargettype.c b/libebl/eblcheckreloctargettype.c index e0d57c1..068ad8f 100644 --- a/libebl/eblcheckreloctargettype.c +++ b/libebl/eblcheckreloctargettype.c @@ -46,6 +46,7 @@ ebl_check_reloc_target_type (Ebl *ebl, Elf64_Word sh_type) case SHT_INIT_ARRAY: case SHT_FINI_ARRAY: case SHT_PREINIT_ARRAY: + case SHT_NOTE: return true; default: -- 1.8.3.1