From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62417 invoked by alias); 21 Feb 2018 16:23:07 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 62401 invoked by uid 89); 21 Feb 2018 16:23:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Feb 2018 16:23:05 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id DE87330008AB for ; Wed, 21 Feb 2018 17:23:03 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id D845A4133191; Wed, 21 Feb 2018 17:23:03 +0100 (CET) Message-ID: <1519230183.3058.98.camel@klomp.org> Subject: Re: [PATCH] libdw: Add support for DWARF5 DW_FORM_data16. From: Mark Wielaard To: elfutils-devel@sourceware.org Date: Wed, 21 Feb 2018 16:23:00 -0000 In-Reply-To: <1518209921-30243-1-git-send-email-mark@klomp.org> References: <1518209921-30243-1-git-send-email-mark@klomp.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2018-q1/txt/msg00048.txt.bz2 On Fri, 2018-02-09 at 21:58 +0100, Mark Wielaard wrote: > The DWARF5 spec says DW_FORM_data16 is constant class (128bit value). > But we treat it as if it is block class. So to use a attribute that is > encoded as DW_FORM_data16 use dwarf_formblock, not dwarf_form[us]data. >=20 > We cannot use dwarf_form[us]data since they return a Dwarf_Word/Sword, > which are only 64bits. >=20 > This does mean we don't try to convert the value but just return it as > a block of 16 raw bytes. Pushed to master.