From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113523 invoked by alias); 20 Mar 2018 12:34:06 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 113506 invoked by uid 89); 20 Mar 2018 12:34:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.4 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy= X-Spam-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Mar 2018 12:34:04 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 5F071302BB23; Tue, 20 Mar 2018 13:34:01 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 34328400B8C0; Tue, 20 Mar 2018 13:34:01 +0100 (CET) From: Mark Wielaard To: elfutils-devel@sourceware.org Cc: Mark Wielaard Subject: [PATCH] readelf: Report error when decl_file or call_file attribute is invalid. Date: Tue, 20 Mar 2018 12:34:00 -0000 Message-Id: <1521549237-15410-1-git-send-email-mark@klomp.org> X-Mailer: git-send-email 1.8.3.1 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2018-q1/txt/msg00083.txt.bz2 Report an error for why the DW_AT_decl_file or DW_AT_call_file cannot be resolved to a file name. This is likely invalid DWARF, a missing DW_AT_stmt_list attribute on the CU or a missing .debug_line section. Signed-off-by: Mark Wielaard --- src/ChangeLog | 5 +++++ src/readelf.c | 18 +++++++++++++++--- 2 files changed, 20 insertions(+), 3 deletions(-) diff --git a/src/ChangeLog b/src/ChangeLog index c879712..f2f99ed 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -1,3 +1,8 @@ +2018-03-20 Mark Wielaard + + * readelf.c (attr_callback): Report error when DW_AT_decl_file or + DW_AT_call_file cannot be resolved. + 2018-03-06 Mark Wielaard * readelf.c (print_ops): Handle DW_OP_addrx, DW_OP_constx, diff --git a/src/readelf.c b/src/readelf.c index fcf5e2c..b1d63ef 100644 --- a/src/readelf.c +++ b/src/readelf.c @@ -6247,11 +6247,23 @@ attr_callback (Dwarf_Attribute *attrp, void *arg) if (dwarf_getsrcfiles (&cudie, &files, &nfiles) == 0) { valuestr = dwarf_filesrc (files, num, NULL, NULL); - char *filename = strrchr (valuestr, '/'); - if (filename != NULL) - valuestr = filename + 1; + if (valuestr != NULL) + { + char *filename = strrchr (valuestr, '/'); + if (filename != NULL) + valuestr = filename + 1; + } + else + error (0, 0, gettext ("invalid file (%" PRId64 "): %s"), + num, dwarf_errmsg (-1)); } + else + error (0, 0, gettext ("no srcfiles for CU [%zx]"), + dwarf_dieoffset (&cudie)); } + else + error (0, 0, gettext ("couldn't get DWARF CU: %s"), + dwarf_errmsg (-1)); } break; default: -- 1.8.3.1