From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80742 invoked by alias); 27 Mar 2018 14:26:06 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 80719 invoked by uid 89); 27 Mar 2018 14:26:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.4 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy=zx X-Spam-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Mar 2018 14:26:04 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 0FF64302BB32 for ; Tue, 27 Mar 2018 16:26:01 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id B7CA9413CD0D; Tue, 27 Mar 2018 16:26:01 +0200 (CEST) Message-ID: <1522160761.15770.61.camel@klomp.org> Subject: Re: [PATCH] readelf: Report error when decl_file or call_file attribute is invalid. From: Mark Wielaard To: elfutils-devel@sourceware.org Date: Tue, 27 Mar 2018 14:26:00 -0000 In-Reply-To: <1522158126.15770.59.camel@klomp.org> References: <1521549237-15410-1-git-send-email-mark@klomp.org> <1522158126.15770.59.camel@klomp.org> Content-Type: multipart/mixed; boundary="=-oPp+JY74D2eBesnEa90J" X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2018-q1/txt/msg00114.txt.bz2 --=-oPp+JY74D2eBesnEa90J Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-length: 1053 On Tue, 2018-03-27 at 15:42 +0200, Mark Wielaard wrote: > On Tue, 2018-03-20 at 13:33 +0100, Mark Wielaard wrote: > > Report an error for why the DW_AT_decl_file or DW_AT_call_file > > cannot > > be resolved to a file name. This is likely invalid DWARF, a missing > > DW_AT_stmt_list attribute on the CU or a missing .debug_line > > section. >=20 > I pushed this to master And the buildbot flagged an issue on debian-i686: https://builder.wildebeest.org/buildbot/#/builders/4/builds/110 readelf.c: In function =E2=80=98attr_callback=E2=80=99: readelf.c:6261:27: error: format =E2=80=98%zx=E2=80=99 expects argument of = type =E2=80=98size_t=E2=80=99, but argument 4 has type =E2=80=98Dwarf_Off {= aka long long unsigned int}=E2=80=99 [-Werror=3Dformat=3D] =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0error (0, 0, gettext ("no srcfiles for CU [%z= x]"), =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0^ Oops. Sorry about that. Fixed as attached. --=-oPp+JY74D2eBesnEa90J Content-Disposition: inline; filename="0001-readelf-Print-dwarf_dieoffset-as-PRIx64-not-zx.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-readelf-Print-dwarf_dieoffset-as-PRIx64-not-zx.patch"; charset="UTF-8" Content-length: 1627 RnJvbSBmMGQ3YjNlMTQ3NzljZGY1ZmFjZWRlOThlZGM5MjRlZjEyNjZiNzg1 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJrIFdpZWxhYXJk IDxtYXJrQGtsb21wLm9yZz4KRGF0ZTogVHVlLCAyNyBNYXIgMjAxOCAxNjoy MjoxNiArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIHJlYWRlbGY6IFByaW50IGR3 YXJmX2RpZW9mZnNldCBhcyAlUFJJeDY0LCBub3QgJXp4LgoKT24gMzJiaXQg YXJjaGl0ZWN0dXJlcyBzaXplX3QgaXMgbm90IDY0Yml0Li4uCgpTaWduZWQt b2ZmLWJ5OiBNYXJrIFdpZWxhYXJkIDxtYXJrQGtsb21wLm9yZz4KLS0tCiBz cmMvQ2hhbmdlTG9nIHwgNSArKysrKwogc3JjL3JlYWRlbGYuYyB8IDIgKy0K IDIgZmlsZXMgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9u KC0pCgpkaWZmIC0tZ2l0IGEvc3JjL0NoYW5nZUxvZyBiL3NyYy9DaGFuZ2VM b2cKaW5kZXggZjJmOTllZC4uMWFkNmIzZCAxMDA2NDQKLS0tIGEvc3JjL0No YW5nZUxvZworKysgYi9zcmMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsOCBAQAor MjAxOC0wMy0yNyAgTWFyayBXaWVsYWFyZCAgPG1hcmtAa2xvbXAub3JnPgor CisJKiByZWFkZWxmLmMgKGF0dHJfY2FsbGJhY2spOiBQcmludCBkd2FyZl9k aWVvZmZzZXQgYXMgJVBSSXg2NCwKKwlub3QgJXp4LgorCiAyMDE4LTAzLTIw ICBNYXJrIFdpZWxhYXJkICA8bWFya0BrbG9tcC5vcmc+CiAKIAkqIHJlYWRl bGYuYyAoYXR0cl9jYWxsYmFjayk6IFJlcG9ydCBlcnJvciB3aGVuIERXX0FU X2RlY2xfZmlsZSBvcgpkaWZmIC0tZ2l0IGEvc3JjL3JlYWRlbGYuYyBiL3Ny Yy9yZWFkZWxmLmMKaW5kZXggOGE5Njg4MS4uNGUzNWI2MSAxMDA2NDQKLS0t IGEvc3JjL3JlYWRlbGYuYworKysgYi9zcmMvcmVhZGVsZi5jCkBAIC02MjU4 LDcgKzYyNTgsNyBAQCBhdHRyX2NhbGxiYWNrIChEd2FyZl9BdHRyaWJ1dGUg KmF0dHJwLCB2b2lkICphcmcpCiAJCQkgICAgIG51bSwgZHdhcmZfZXJybXNn ICgtMSkpOwogCQkgIH0KIAkJZWxzZQotCQkgIGVycm9yICgwLCAwLCBnZXR0 ZXh0ICgibm8gc3JjZmlsZXMgZm9yIENVIFslenhdIiksCisJCSAgZXJyb3Ig KDAsIDAsIGdldHRleHQgKCJubyBzcmNmaWxlcyBmb3IgQ1UgWyUiIFBSSXg2 NCAiXSIpLAogCQkJIGR3YXJmX2RpZW9mZnNldCAoJmN1ZGllKSk7CiAJICAg ICAgfQogCSAgICBlbHNlCi0tIAoxLjguMy4xCgo= --=-oPp+JY74D2eBesnEa90J--