From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126023 invoked by alias); 11 Apr 2018 08:47:35 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 126001 invoked by uid 89); 11 Apr 2018 08:47:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.4 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy=r30, elr, r29 X-Spam-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Apr 2018 08:47:33 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 93D2030008A2; Wed, 11 Apr 2018 10:47:28 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id C78644000F03; Wed, 11 Apr 2018 10:47:28 +0200 (CEST) From: Mark Wielaard To: elfutils-devel@sourceware.org Cc: Mark Wielaard Subject: [PATCH] aarch64: Add default cfi rule to restore SP from CFA address. Date: Wed, 11 Apr 2018 08:47:00 -0000 Message-Id: <1523436446-11419-1-git-send-email-mark@klomp.org> X-Mailer: git-send-email 1.8.3.1 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2018-q2/txt/msg00006.txt.bz2 The CFA is set by default to the stack pointer of the previous frame. So that is also how we can always restore the SP. This default aarch64 CFI rule is necessary on Fedora 28 with GCC8 to make the run-deleted.sh and run-backtrace-dwarf.sh testcases work. Signed-off-by: Mark Wielaard --- backends/ChangeLog | 5 +++++ backends/aarch64_cfi.c | 7 +++++-- tests/ChangeLog | 4 ++++ tests/run-addrcfi.sh | 2 +- 4 files changed, 15 insertions(+), 3 deletions(-) diff --git a/backends/ChangeLog b/backends/ChangeLog index b525801..57baea0 100644 --- a/backends/ChangeLog +++ b/backends/ChangeLog @@ -1,3 +1,8 @@ +2018-04-11 Mark Wielaard + + * aarch64_cfi.c (aarch64_abi_cfi): Add rule for restoring SP from + CFA address. + 2018-02-15 Mark Wielaard * ppc_initreg.c: Include ptrace.h before system.h and sys/user.h. diff --git a/backends/aarch64_cfi.c b/backends/aarch64_cfi.c index acbb9b6..a5579ab 100644 --- a/backends/aarch64_cfi.c +++ b/backends/aarch64_cfi.c @@ -1,5 +1,5 @@ -/* arm ABI-specified defaults for DWARF CFI. - Copyright (C) 2013 Red Hat, Inc. +/* arm64 ABI-specified defaults for DWARF CFI. + Copyright (C) 2013, 2018 Red Hat, Inc. This file is part of elfutils. This file is free software; you can redistribute it and/or modify @@ -62,6 +62,9 @@ aarch64_abi_cfi (Ebl *ebl __attribute__ ((unused)), Dwarf_CIE *abi_info) /* The Frame Pointer (FP, r29) and Link Register (LR, r30). */ SV (29), SV (30), + /* The Stack Pointer (r31) is restored from CFA address by default. */ + DW_CFA_val_offset, ULEB128_7 (31), ULEB128_7 (0), + /* Callee-saved fpregs v8-v15. v0 == 64. */ SV (72), SV (73), SV (74), SV (75), SV (76), SV (77), SV (78), SV (79), diff --git a/tests/ChangeLog b/tests/ChangeLog index fea1d17..bcd7b47 100644 --- a/tests/ChangeLog +++ b/tests/ChangeLog @@ -1,3 +1,7 @@ +2018-04-11 Mark Wielaard + + * run-addrcfi.sh: Adjust expected rule for aarch64 sp. + 2018-03-06 Mark Wielaard * varlocs.c (print_expr): Handle DW_OP_implicit_pointer, diff --git a/tests/run-addrcfi.sh b/tests/run-addrcfi.sh index 376a6dc..fd89d02 100755 --- a/tests/run-addrcfi.sh +++ b/tests/run-addrcfi.sh @@ -3637,7 +3637,7 @@ dwarf_cfi_addrframe (.eh_frame): no matching address range integer reg28 (x28): same_value integer reg29 (x29): same_value integer reg30 (x30): same_value - integer reg31 (sp): undefined + integer reg31 (sp): location expression: call_frame_cfa stack_value integer reg33 (elr): undefined FP/SIMD reg64 (v0): undefined FP/SIMD reg65 (v1): undefined -- 1.8.3.1