From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94133 invoked by alias); 13 Apr 2018 11:43:51 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 94093 invoked by uid 89); 13 Apr 2018 11:43:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.4 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Apr 2018 11:43:48 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 099C330008AD for ; Fri, 13 Apr 2018 13:43:46 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id F1778413CEBB; Fri, 13 Apr 2018 13:43:45 +0200 (CEST) Message-ID: <1523619825.13039.1.camel@klomp.org> Subject: Re: [PATCH] libdwfl: Handle unwind frame when the return address register isn't set. From: Mark Wielaard To: elfutils-devel@sourceware.org Date: Fri, 13 Apr 2018 11:43:00 -0000 In-Reply-To: <1523370202-534-1-git-send-email-mark@klomp.org> References: <1523370202-534-1-git-send-email-mark@klomp.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6 (3.22.6-14.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2018-q2/txt/msg00008.txt.bz2 On Tue, 2018-04-10 at 16:23 +0200, Mark Wielaard wrote: > When we have unwound the frame and then cannot set the return address > we wouldn't set any error. That meant that a dwfl_thread_getframes () > call could end in an error, but without any dwfl_errno set, producing > the "no error" error message. >=20 > If we cannot set the return address at the end of unwinding the frame > that means that either the return address register is bogus (error), > or that the return address is undefined (end of the call stack). >=20 > This fixes the run-backtrace-native-biarch.sh testcase for me on an > i386 on x86_64 setup with gcc 7.2.1 and glibc 2.17. Pushed to master.