From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44394 invoked by alias); 11 May 2018 15:25:34 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 44373 invoked by uid 89); 11 May 2018 15:25:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.4 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=BAYES_00,GIT_PATCH_1,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,GIT_PATCH_1,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 11 May 2018 15:25:33 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id D0854310E0BC for ; Fri, 11 May 2018 17:25:30 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 89530413CB3E; Fri, 11 May 2018 17:25:30 +0200 (CEST) Message-ID: <1526052330.3097.59.camel@klomp.org> Subject: Re: [PATCH] libdw: Handle DWARF5 line tables in dwarf_getsrclines. From: Mark Wielaard To: elfutils-devel@sourceware.org Date: Fri, 11 May 2018 15:25:00 -0000 In-Reply-To: <1525730763-17612-1-git-send-email-mark@klomp.org> References: <1525730763-17612-1-git-send-email-mark@klomp.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6 (3.22.6-14.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2018-q2/txt/msg00032.txt.bz2 On Tue, 2018-05-08 at 00:06 +0200, Mark Wielaard wrote: > In DWARF5 the actual line number table format doesn't change, except for > not allowing DW_LNE_define_file (but we still just accept it). The > changes are the header having new fields for address and segment > selector sizes, and new formats for the directory and file names tables. >=20 > The directory and file name tables are much more flexible in DWARF5, but > we only interpret the actual names and file/dir index relationships, > skipping/ignoring any other information. There also is no new interface > yet to get at the new directory and file properties. >=20 > There is some small confusion about the file name table indexing. Older > DWARF versions explicitly called the first file name table 1. DWARF5 > implies the first index is 0 (but for file attributes, zero means not > associated with a file). We get away with that by having an actual zero > index for older DWARF versions (the null_fill). It looks like gcc gets > around it by explicitly duplicating the first (0) and second (1) file > name entry in the table. This can also be seen in the new testcase. >=20 > The patch looks big because of moving a few initializations around > and because the code that is different for older/newer DWARF got moved > under if statements. But the original old DWARF code path didn't really > change. Pushed to master.