From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30212 invoked by alias); 29 May 2018 10:12:29 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 30200 invoked by uid 89); 29 May 2018 10:12:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.4 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 29 May 2018 10:12:27 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id B4FAA30008C1 for ; Tue, 29 May 2018 12:12:25 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id A1D1F4110E22; Tue, 29 May 2018 12:12:25 +0200 (CEST) Message-ID: <1527588745.12946.5.camel@klomp.org> Subject: Re: [PATCH] libdwfl: Allow partial relocations also for debug files. From: Mark Wielaard To: elfutils-devel@sourceware.org Date: Tue, 29 May 2018 10:12:00 -0000 In-Reply-To: <1527423205-15293-1-git-send-email-mark@klomp.org> References: <1527423205-15293-1-git-send-email-mark@klomp.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6 (3.22.6-14.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2018-q2/txt/msg00099.txt.bz2 On Sun, 2018-05-27 at 14:13 +0200, Mark Wielaard wrote: > __libdwfl_relocate is called for get_dwarf and get_elf. We allow not all > relocations to be resolved for Elf files, but required all relocations > (in the debug sections) to be fully resoled in Dwarf files. This used to > mostly work out with .o ET_REL files when the main Elf was gotten before > the Dwarf. But with .dwo files, we (readelf) might open the .o file just > for the (skeleton) Dwarf. In this case it could happen not all relocations > in the debug sections could be resolved (.debug_info and .debug_addr might > contain referenes to undefined symbols). So allow partial relocations > also for debug files. Pushed to master.