From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5180 invoked by alias); 30 May 2018 12:59:09 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 5037 invoked by uid 89); 30 May 2018 12:59:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.4 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:477 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 30 May 2018 12:59:05 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 40CE93000913 for ; Wed, 30 May 2018 14:59:03 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 0ED314158C43; Wed, 30 May 2018 14:59:03 +0200 (CEST) Message-ID: <1527685142.12946.19.camel@klomp.org> Subject: Re: [PATCH] libdw: Fix memory corruption in libdw_find_split_unit. From: Mark Wielaard To: elfutils-devel@sourceware.org Date: Wed, 30 May 2018 12:59:00 -0000 In-Reply-To: <1527521631-27551-1-git-send-email-mark@klomp.org> References: <1527521631-27551-1-git-send-email-mark@klomp.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6 (3.22.6-14.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2018-q2/txt/msg00118.txt.bz2 On Mon, 2018-05-28 at 17:33 +0200, Mark Wielaard wrote: > Found by valgrind when trying to match a split unit from a .dwo file > that doesn't contain the split unit (as first) match. We would close > the split Dwarf too early, before we had inspected all units in it. >=20 > Add a testcase that simulates this. Which failed (at least under valgrind > as run by make distcheck) before the fix. Pushed to master.