From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20188 invoked by alias); 31 May 2018 12:22:57 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 20173 invoked by uid 89); 31 May 2018 12:22:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.4 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 31 May 2018 12:22:54 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id C52E630008B4 for ; Thu, 31 May 2018 14:22:52 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id B41C440B9DED; Thu, 31 May 2018 14:22:52 +0200 (CEST) Message-ID: <1527769372.12946.27.camel@klomp.org> Subject: Re: [PATCH] readelf: Fix regression with multiple files and implicit debug_info reading. From: Mark Wielaard To: elfutils-devel@sourceware.org Date: Thu, 31 May 2018 12:22:00 -0000 In-Reply-To: <1527580648-18586-1-git-send-email-mark@klomp.org> References: <1527580648-18586-1-git-send-email-mark@klomp.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6 (3.22.6-14.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2018-q2/txt/msg00123.txt.bz2 On Tue, 2018-05-29 at 09:57 +0200, Mark Wielaard wrote: > Commit 314e9d7d "readelf: Handle .debug_info first if any other debug > section needs it" introduced a regression when handling multiple files. > The implicit and explicit printing of debuginfo weren't reset and so > the second file would not show (or scan) the .debug_info section when > needed. >=20 > Fix by resetting the implicit and explicit section printing flags. > Add a testcase that prints the .debug_loc section for two files and > check that the CUs are resolved. Pushed to master.