From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16380 invoked by alias); 31 May 2018 15:06:39 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 16358 invoked by uid 89); 31 May 2018 15:06:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.4 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 31 May 2018 15:06:37 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 4E1E430007B4 for ; Thu, 31 May 2018 17:06:35 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 0503C40B9DED; Thu, 31 May 2018 17:06:35 +0200 (CEST) Message-ID: <1527779194.12946.30.camel@klomp.org> Subject: Re: [PATCH] libdw: Handle split Dwarf Dies in dwarf_die_addr_die. From: Mark Wielaard To: elfutils-devel@sourceware.org Date: Thu, 31 May 2018 15:06:00 -0000 In-Reply-To: <1527631870.12946.9.camel@klomp.org> References: <1527631066-31956-1-git-send-email-mark@klomp.org> <1527631870.12946.9.camel@klomp.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6 (3.22.6-14.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2018-q2/txt/msg00126.txt.bz2 On Wed, 2018-05-30 at 00:11 +0200, Mark Wielaard wrote: > On Tue, 2018-05-29 at 23:57 +0200, Mark Wielaard wrote: > > dwarf_die_addr_die can be used to turn an Dwarf_Die addr back into a > > full Dwarf_Die, just given the original Dwarf debug handle. This now > > also works for Dwarf_Dies which originated from a split Dwarf. Whenever > > a split Dwarf_CU is found the Dwarf it originated from is registered > > with the Dwarf that the skeleton Dwarf_CU came from. All registered > > split Dwarfs are then searched by dwarf_die_addr_die if the addr didn't > > match the main Dwarf or the alt Dwarf. > >=20 > > One limitation in this implementation is that only DIEs that come from > > the main .debug_info in the .dwo are supported. Theoretically there cou= ld > > also be DIEs in an .debug_type or from other/multiple (comdat) sections. > >=20 > > New tests are added for dwarf-4, dwarf-5, split-dwarf-4, split-dwarf-5 > > and version 4 and 5 dwo files. >=20 > And clearly I hadn't done a make distcheck because then I would have > known that valgrind would warn about leaking the new search tree. Pushed to master, including the tdestoy fix for the leak.