From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110053 invoked by alias); 8 Jun 2018 14:22:01 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 110017 invoked by uid 89); 8 Jun 2018 14:22:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.4 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 08 Jun 2018 14:21:59 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 66F71301470D for ; Fri, 8 Jun 2018 16:21:57 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 337E0413CB92; Fri, 8 Jun 2018 16:21:57 +0200 (CEST) Message-ID: <1528467717.12946.78.camel@klomp.org> Subject: Re: [PATCH] tests: Use error, not assert, when trying to print a non-base type DIE. From: Mark Wielaard To: elfutils-devel@sourceware.org Date: Fri, 08 Jun 2018 14:22:00 -0000 In-Reply-To: <20180606214358.7348-1-mark@klomp.org> References: <20180606214358.7348-1-mark@klomp.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6 (3.22.6-14.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2018-q2/txt/msg00185.txt.bz2 On Wed, 2018-06-06 at 23:43 +0200, Mark Wielaard wrote: > When using the varlocs test with a fuzzer using assert for internal > sanity checks is great to find issues. But when encountering bad data > using an assert is wrong. Just use error to show we handle the data > correctly (by reporting it is bad, instead of crashing). Pushed to master.