From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102801 invoked by alias); 10 Jun 2018 09:05:27 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 102787 invoked by uid 89); 10 Jun 2018 09:05:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.4 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=BAYES_00,GIT_PATCH_1,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=pointing, Hx-languages-length:747, DWARF X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,GIT_PATCH_1,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 10 Jun 2018 09:05:24 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id A29E5301470D for ; Sun, 10 Jun 2018 11:05:21 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 563AE413CB92; Sun, 10 Jun 2018 11:05:21 +0200 (CEST) Message-ID: <1528621521.12946.84.camel@klomp.org> Subject: Re: [PATCH] libdw: Return an error in dwarf_getlocation_attr for missing .debug_addr. From: Mark Wielaard To: elfutils-devel@sourceware.org Date: Sun, 10 Jun 2018 09:05:00 -0000 In-Reply-To: <1528451701-12732-1-git-send-email-mark@klomp.org> References: <1528451701-12732-1-git-send-email-mark@klomp.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6 (3.22.6-14.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2018-q2/txt/msg00194.txt.bz2 On Fri, 2018-06-08 at 11:55 +0200, Mark Wielaard wrote: > When constructing a "fake" Dwarf_Attribute for DW_OP_GNU_const_index, > DW_OP_constx, DW_OP_GNU_addr_index or DW_OP_addrx, we would create a > fake attribute pointing to the actual data in the .debug_addr section. >=20 > We would even do that if there was no .debug_addr section assuming > dwarf_formaddr or dwarf_formudata would generate an error. But when > there is no .debug_addr there is also no fake_addr_cu, so the > dwarf_form* functions cannot check the value is correct (and crash). >=20 > Fix by returning an error early from dwarf_getlocation_attr indicating > bad DWARF data. Pushed to master.