From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39953 invoked by alias); 20 Jun 2018 11:16:56 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 39919 invoked by uid 89); 20 Jun 2018 11:16:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.4 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=risks, trickery X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Jun 2018 11:16:51 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id DC0A9301306B; Wed, 20 Jun 2018 13:16:48 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id AA9BC4337300; Wed, 20 Jun 2018 13:16:48 +0200 (CEST) Message-ID: <1529493408.12946.131.camel@klomp.org> Subject: Re: [PATCH] backends: add abi_cfi and register_info callbacks for RISC-V From: Mark Wielaard To: Andreas Schwab Cc: elfutils-devel@sourceware.org Date: Wed, 20 Jun 2018 11:16:00 -0000 In-Reply-To: References: <20180614232812.GG7539@wildebeest.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6 (3.22.6-14.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2018-q2/txt/msg00237.txt.bz2 Hi Andreas, On Mon, 2018-06-18 at 09:59 +0200, Andreas Schwab wrote: > On Jun 15 2018, Mark Wielaard wrote: >=20 > > How does the result of make check look now on a native riscv > > system? >=20 > FAIL: run-native-test.sh >=20 > return_value_location is missing Sadly DWARF doesn't describe how return values are passed back. So you'll have to write that by hand for the abi. It normally isn't that hard for scalar types, sometimes there is some trickery for floats or small structs. > FAIL: run-low_high_pc.sh >=20 > lowpc: 220, highpc: 220lx > ../../elfutils/src/size.c: [c84] 'handle_elf' highpc <=3D lowpc >=20 > lowpc: 41c, highpc: 41clx > ../../elfutils/src/strip.c: [1c00] 'update_section_size' highpc <=3D > lowpc That is odd. For which testfile is this? Is it for a native (self test) file? If it is for an ET_REL object file it might be that we don't handle all relocations correctly. If you could post the file somewhere, that might be helpful to track down the issue. > FAIL: run-backtrace-native.sh > FAIL: run-backtrace-dwarf.sh > FAIL: run-deleted.sh >=20 > set_initial_registers_tid is missing If the target has ptrace support this probably wouldn't be too hard to get going. > FAIL: run-backtrace-native-core.sh >=20 > no corefile support That would need a corenote backend implementation. > SKIP: run-backtrace-data.sh >=20 > no unwinding support That is expected. It really is an architecture specific (x86_64) test. > > Could you provide a testcase for tests/run-allregs.sn and/or > > tests/run-addrcfi.sh if possible so people can check things work on > > other arches? > >=20 > > If this is enough to actually unwind could you look at providing an > > tests/run-backtrace-core-riscv.sh testcase (the existing ones > > should > > explain how to generate the (static) executable and core file for > > the > > test, but if it is unclear please ask. >=20 > I will work on these. Thanks. Without tests it is hard to know if an arch is really fully functional and it risks bit-rotting. I have added a ChangeLog entry for your patch and pushed it to master. Cheers, Mark