From: Mark Wielaard <mark@klomp.org>
To: Andreas Schwab <schwab@suse.de>
Cc: Ulf Hermann <ulf.hermann@qt.io>, elfutils-devel@sourceware.org
Subject: Re: [PATCH 2/2] run-strip-reloc.sh: Skip debug file check for riscv
Date: Tue, 17 Jul 2018 10:05:00 -0000 [thread overview]
Message-ID: <1531821926.3153.56.camel@klomp.org> (raw)
In-Reply-To: <mvm8t6a1a83.fsf@suse.de>
On Tue, 2018-07-17 at 11:29 +0200, Andreas Schwab wrote:
> On Jul 17 2018, Mark Wielaard <mark@klomp.org> wrote:
> > The issue is that hello_riscv64.ko doesn't contain any debug
> > sections.
> > So strip doesn't produce a separate debug file.
> >
> > Andreas, could you provide an updated hello_riscv64.ko that is
> > compiled
> > with -g and does contain debuginfo?
>
> What is the issue? The test worksforme.
The problem is that the test is designed to see that strip works to
properly to remove the .debug sections and remove relocations against
.debug sections for a .ko file. But the hello_riscv64.ko file doesn't
contain any .debug sections so it trivially succeeds. Ulf fixed the
test to make sure strip actually does any work by removing the old
debug files. This shows the current hello_riscv64.ko failing.
If you could regenerate the file with -g so that it does contain .debug
sections that would help us fix the testcase.
Thanks,
Mark
next prev parent reply other threads:[~2018-07-17 10:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 10:02 Ulf Hermann
2018-07-16 22:01 ` Mark Wielaard
2018-07-17 9:29 ` Andreas Schwab
2018-07-17 9:49 ` Ulf Hermann
2018-07-17 10:06 ` Andreas Schwab
2018-07-17 10:05 ` Mark Wielaard [this message]
2018-07-17 10:09 ` Andreas Schwab
2018-07-17 10:33 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1531821926.3153.56.camel@klomp.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=schwab@suse.de \
--cc=ulf.hermann@qt.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).