From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47891 invoked by alias); 17 Jul 2018 10:33:52 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 47835 invoked by uid 89); 17 Jul 2018 10:33:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.0 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:742 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Jul 2018 10:33:51 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 182F630014D2; Tue, 17 Jul 2018 12:33:49 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 1023F40919B2; Tue, 17 Jul 2018 12:33:49 +0200 (CEST) Message-ID: <1531823628.3153.59.camel@klomp.org> Subject: Re: [PATCH 1/2] Remove previous test files before running the next round From: Mark Wielaard To: Ulf Hermann Cc: elfutils-devel@sourceware.org Date: Tue, 17 Jul 2018 10:33:00 -0000 In-Reply-To: <20180716215755.GA8971@wildebeest.org> References: <87ac4132-25a7-cb0a-e3f0-a6c5495f0426@qt.io> <20180716215755.GA8971@wildebeest.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6 (3.22.6-14.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2018-q3/txt/msg00027.txt.bz2 On Mon, 2018-07-16 at 23:57 +0200, Mark Wielaard wrote: > On Mon, Jul 16, 2018 at 12:01:21PM +0200, Ulf Hermann wrote: > > strip explicitly creates the new files. This will not work on > > windows if > > the files already exist. > >=20 > > Also, if strip fails to create the files for any reason, we would > > check > > the previous run's files and succeed. However, the test should fail > > then. >=20 > This makes sense and does uncover a bug as your second patch shows. > I want to fix that first and only then commit this fix. That way we > don't have the testsuite failing between commits. Pushed now that we have an updated hello_riscv64.ko test file. Thanks, Mark