From: Mark Wielaard <mark@klomp.org>
To: Andreas Schwab <schwab@suse.de>
Cc: elfutils-devel@sourceware.org
Subject: Re: [PATCH] backends: add abi_cfi and register_info callbacks for RISC-V
Date: Thu, 26 Jul 2018 16:03:00 -0000 [thread overview]
Message-ID: <1532620979.12909.38.camel@klomp.org> (raw)
In-Reply-To: <mvmh8ko202y.fsf@suse.de>
On Tue, 2018-07-24 at 16:13 +0200, Andreas Schwab wrote:
> How about this, does it look reasonable? It doesn't handle SET6/SUB6
> yet, and eu-readelf -wframe doesn't agree with readelf -wf, so this
> is only a RFC.
I don't really like adding not really existing types to the translation
types ELF_T_... I rather see the add/sub part be done as extra argument
to the reloc_simple_type callback. Maybe simply as an int addsub, which
can be -1, 0, 1. It does mean more code needs to be adjusted, but this
is an internal interface, so it can just be changed.
Thanks,
Mark
next prev parent reply other threads:[~2018-07-26 16:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 10:28 Andreas Schwab
2018-06-14 23:28 ` Mark Wielaard
2018-06-18 8:01 ` Andreas Schwab
2018-06-20 11:16 ` Mark Wielaard
2018-06-20 12:38 ` Andreas Schwab
2018-06-20 12:59 ` Mark Wielaard
2018-06-20 13:55 ` Andreas Schwab
2018-06-20 20:49 ` Mark Wielaard
2018-07-11 13:40 ` Andreas Schwab
2018-07-24 14:13 ` Andreas Schwab
2018-07-26 16:03 ` Mark Wielaard [this message]
2018-10-02 12:46 ` [PATCH] Handle ADD/SUB relocations Andreas Schwab
2018-10-13 21:23 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1532620979.12909.38.camel@klomp.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).