From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86429 invoked by alias); 27 Jul 2018 12:24:39 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 86335 invoked by uid 89); 27 Jul 2018 12:24:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.1 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 27 Jul 2018 12:24:36 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 224D6307C538 for ; Fri, 27 Jul 2018 14:24:34 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 1C5BB4000ABE; Fri, 27 Jul 2018 14:24:34 +0200 (CEST) Message-ID: <1532694274.24471.2.camel@klomp.org> Subject: Re: [PATCH] unstrip: Also check sh_size in compare_unalloc_sections. From: Mark Wielaard To: elfutils-devel@sourceware.org Date: Fri, 27 Jul 2018 12:24:00 -0000 In-Reply-To: <1532470505-20077-1-git-send-email-mark@klomp.org> References: <1532470505-20077-1-git-send-email-mark@klomp.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6 (3.22.6-14.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2018-q3/txt/msg00051.txt.bz2 On Wed, 2018-07-25 at 00:15 +0200, Mark Wielaard wrote: > compare_unalloc_sections only checked sh_flags and the section names. > This would cause stripped/debug section mismatches when there were > multiple sections with the same name and flags. Fix this by also > checking the size of the section matches. Pushed to master.