From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126743 invoked by alias); 20 Apr 2017 14:40:47 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 126609 invoked by uid 89); 20 Apr 2017 14:40:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-Spam-Status: No, score=-25.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: EUR01-HE1-obe.outbound.protection.outlook.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qtcompany.onmicrosoft.com; s=selector1-qt-io; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=DXA7/jCUHHx6Y6W/oPUGbFEZarHaKpySMk/s24/efQU=; b=tRF7Gq8Ma4i85R1/8FzffypsirHDLrP8nCkHonBYp4JfCRVEzmwcDpuRvcIyDob3lMN8J/imYybSYlOrWD40HUCLoewRSwuppecf7FlsaQDfrM9S/4akn+SpYpNyB6B6b/5OqQg1gMNqWF8RKmbvwQjT4/xTvdFCJpLBZZJJF6s= Authentication-Results: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=qt.io; From: Ulf Hermann Subject: [PATCH] Avoid signed/unsigned comparison To: Message-ID: <1544575c-bba2-f196-3485-eb56b206b3d0@qt.io> Date: Thu, 20 Apr 2017 14:40:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.6.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [62.220.2.194] X-ClientProxiedBy: VI1PR0802CA0024.eurprd08.prod.outlook.com (10.172.253.162) To DB5PR0201MB1863.eurprd02.prod.outlook.com (10.167.225.149) X-MS-Office365-Filtering-Correlation-Id: cb9f8d24-0935-4554-e968-08d487fb3447 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:DB5PR0201MB1863; X-Microsoft-Exchange-Diagnostics: 1;DB5PR0201MB1863;3:h/BCT4xkPhxW2Y6cRm0eucPxqnuOI5nIFElgU70gnsaiuyMJbmyKPIfG6TU+0s35btz8lfchYNLKrNxans4MTz9Wkcaf4XYYM7q6lg3FqmARLobphiH9ZP2asrrJhEdRbikhbxGt5dL0fpZDrlYI/AiPQCss4q/u4A5PL2iZTcQAfSQ0m4TiHhwyDGV80n/TnzU9xTiA298x6JaGGWyjsIFtmj4JC7JLWJ6qfpjCV3EVaO/XcnwyusTIz5cCQzyjQfpMcyKIn01quGZz7jceIOX9+Sm2YbSv8DP2t0P4eRG6EVD9x28WjYaVVBdd3m+5hWA8o0nmo8DDhrUo9RAn9w==;25:YoTd2Zail4vBOPi9uyqzYPRLv4QzmUMvRuGm6qPKoAA83NU2Y/1jbeQOL2qedw8bi5YxD1VLtrvuH320Z2FWFfutHZ+a5dmV3QDtCKqPPUMgVnJcISx4lbnpchblPWMzSZ8uw+WurdV6036wzcaZAPRI0cgOKnv82nxvEhZKgjILMW1El5/xNNsFBwHyxvqoUql2DiC6x1o4WgkwN72Gfx7mq70CJIVxfbCAMWAVPE0HznTe7az2tBNd2FLTX1EskmPquWwQKV9fSR6ZG5dny3gloM8RyCN+TIfgk4iz8at2jI9v+HhKZAiwNLlKb4DitlY7hz2rRzWk1CIxlkk0uJN5/jIcIySMm+zbhVDZF7i3fiWg4iw6VT+3UG3AujFJSvZrswkgcfJ95par2x+QmjMiI/gccHJLboFL6lOE+JowPKHt7LmWRj+Y64BEeEbUjWlQ9p/NG9X3d5PAYA+l3g== X-Microsoft-Exchange-Diagnostics: 1;DB5PR0201MB1863;31:Tsux05JkiGXTr5PIM00maKIsAV3gJe17X1iS0Inm0TexXmvlc5OS71LJEW9Z+FP2Z09DI9Jmi6QC7I7x7RgvLXKUc/AbkTBkETYgpRRBKAMllVb1z7gd87bpwZGAP8nXUK1ns5wpA+FjLvAPWTL4onZzza0ZJD4sOouxQSdb9OevhZ/GH3+sDAV9PvP78+TP5jtQVigTDr2DVAHQ7fn4edpJlT8pm3NSO3vpJ4z3H6Om3JtMxNM95K6TrLQZZmIrT3kAPVuFy+5pPzusPz57NlD2a2NGPn20vZT9ASh4vq4=;20:V6p3thPHwFfCWa963a5LB68cYwtrqzkKpPiR8L7qf3DFRLEgtYrwfisYMXEQsA7/QZ9XafpqDdWvs3VqYhz9VcjUTTIvNhUBjM1fUW5Jn/jiurWp+80jYmaaJpF6PqW6cPOho4FKWF/c8qMZT5LHpN8a6OHzmClfWOgwziVF2DVnPg1BAQz1RqI1mzisM8P4H5aLqVRV05Lx+lpmdnb9/cQdqHLGtPQHg7Tw7vAALADzKYI5s6QzpLEmTA3jEPu3 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(6041248)(201703131423075)(201702281528075)(201703061421075)(20161123562025)(20161123560025)(20161123555025)(20161123564025)(6072148);SRVR:DB5PR0201MB1863;BCL:0;PCL:0;RULEID:;SRVR:DB5PR0201MB1863; X-Microsoft-Exchange-Diagnostics: 1;DB5PR0201MB1863;4:geVvW16P1G1cHsmkCERqPsdM2RdfCU8lAc9Dw3B04oDU8ESR80aKOghw2cWdY75Vrt1HYhMr3zm+dlTHAZJSqSp+YyDF4CsJwtdmWRlDrmL3ZFvIq6+i5wmBWcEa8dEO60pPKdF05BfxgYqY3sOCqkfld8E/DgPBU7JOpNYfckrkshgZ83Osw94WJM5alBY4Hgc9IyaOuJkae0DXAdBoZRFHzxsRSV4dHsNAT9UTDX1f7A35tqRwHdOgQ/1/od/fYXRNf8j3dDdjo1/jKGeLDkoCQRnm5ITzeL5Y23/pckpGSovck+W1DTluEziXKEhn7iUEG/P513V6+GaExss/+gzyRyRAKhXU1D5+Kq0sHWTHFrsNJ48Z+9ZOHSPGGom5ET/Jb4Y0FSP4xNmHRjUGceWVoXvqHNQCpUKeH2zMVuVQFxALfou6Ol3fWiURbQH4wfdjo71xpAOD5igS7XOIpv6XVTPhvv1XgIbEz1ltLcU0TeC8TUXM6NOuWzIgWggUTA3SGtumekgEV7almC+z+nsWAUGFR2kCf1oewe/uO9RZ3a76Xpdl8jg5NV9wSWFwa5usQ4Qd4nza1XO1zGIM4zdNyuU08NrsjZrxir02IOj26B9qUlBvR3JDztPKdH5EMCWuRTcHHT5TIfbyVXkzhF3NXcO5Szo+EjOM7Z6KMdaBFQGdO41sSkNEsFW31sbON5FKDGgUD1S6jvaYfFi4Lw== X-Forefront-PRVS: 02830F0362 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(39400400002)(39450400003)(39410400002)(39830400002)(377424004)(53936002)(50466002)(6666003)(6916009)(6486002)(5660300001)(77096006)(74482002)(189998001)(2351001)(31686004)(42186005)(33646002)(110136004)(31696002)(86362001)(38730400002)(575784001)(23676002)(54356999)(50986999)(47776003)(81166006)(8676002)(3846002)(25786009)(66066001)(36756003)(6116002)(7736002)(2906002)(305945005)(230700001);DIR:OUT;SFP:1102;SCL:1;SRVR:DB5PR0201MB1863;H:[10.9.78.56];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjVQUjAyMDFNQjE4NjM7MjM6dVJXcFI3L3E3Lzl6djhEbC9yK20zRlM0?= =?utf-8?B?My9rUDkzRGJHR0kvdzZTZVB1Tzd5RzhWRFRlUi9pK0ZGVVg3ZDlsMFI1YjZa?= =?utf-8?B?RlRpWFQ2K3dxd0Fza1RIbEdJaHo1aVJuek1mV0NCbU1SaS9Bd3VGbHdWOGZC?= =?utf-8?B?cmlybXVMV05RRUcraVJUZ3lFN2dyQjkzckVCak10VXBJYktzOWlBZU4zKzhv?= =?utf-8?B?WXVKb1JYUGZxNlN5c0JOVThyWTZ0QkVUcEdRbzB1Q2JuWjB0SlhjckhYazN2?= =?utf-8?B?Z0tlTEZrT3FGbGEvL2RuTE1LdURNRjZBc2hPZVIvREkwZzBJcVhnSjc0ai9Z?= =?utf-8?B?OXNDRTVlaXpvU2NUQ1gxYkxOSU1yNkwvbjVvNDRkN28xa3FuaXY5TFdKaEx2?= =?utf-8?B?N21yc3BFVEVuUDgwTGZtNGtTY0QxNGNjNFY2aC9XVkxHU2NMeFFqY2ZXYTg0?= =?utf-8?B?aTlCSmFFM2c3NmYzN0RoZFlQQ1pLdm9vOThQV3FObE9qcGtYSHJHSDFrdHda?= =?utf-8?B?VjluekJqZkFyU204U284bWZQMHk5WmpWQi9nb285enk2QnhkbjlPbXZBV3lr?= =?utf-8?B?WXRkS0lONTRpcjBhSDE0SnJOWFpUQmduZ1cxbXJZT2hwL1Q5Z2xuV0paSE1k?= =?utf-8?B?ZFhzd3RQTE54OHpKSTQvVjdWSmVDdnQ2TkF2MjNEUmtsNkhmT0tZdVJodTdr?= =?utf-8?B?aHVyWEc5c0dUd1Q4VStUSThEMHhmZUh1YzJiaGVFd1QvTDNFZ1RzUE83OEM5?= =?utf-8?B?VGRUQjQwQUFKS1BQckNyVzFWZHVwYkE5TDZiMDJ1TExOUmx0OGJYcDhHclBs?= =?utf-8?B?VVcvWWkyR3djUnFvQzc5aEpJM0swdUxJSmVETm1WK3hMRVRQRnQvMEpiaDEr?= =?utf-8?B?WWRvQmtjcklUR1REaHVtN0F1Vzh1Q2ZqaU4xL3lxMURFUEIrTWIyNWhyNUFX?= =?utf-8?B?cjMyYzFFWlpyTlJHT3E4aU0wWW44Vm1xc0NQbUNsRHdXNVdyNTZHcDd1SkhF?= =?utf-8?B?eVhuRkJsNG5rV1JYYUE4WFBhZDFUdUdFTWZ2clBkWkFDQ0JING9mTnY2cy9x?= =?utf-8?B?U0JOdWxNSzFBWlR2T0dOVzRCS1ZjMlQ1MnlrQ0grbStLakoxeTA1L3pEM3Ux?= =?utf-8?B?Y2laUDZ0d1ZwS1FOWlJ2N3VTWVpDYmIxOXBwWmo3eTdUWmJzeEIzVnVEOUZP?= =?utf-8?B?WHYzTU5HamlaNzNvMENWamxrREQ1c0IwSVdidm84VU9wbnJCWG9iSXArTEQ2?= =?utf-8?B?Y2tMZUs3L25sQW1OeHJKY0RwM1JBRFdtbUlEcnFldFg4eW9qc2RVT25MQ082?= =?utf-8?B?bnRmdTJ4anVSamtjS1FhMG5oWmFHNi92a1ZZb0R4Z01URm54ckY4VHk5UUVQ?= =?utf-8?B?aU1JTEwyTURMSDVZVG1FU05QZjVTZWgxUlBBRVlVanc9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;DB5PR0201MB1863;6:LujmQbxRudT16ymY7mObSl3MT6V09FJD1d8+UoyMWM28fvrn075uYgNLOo7QLr7B+gdYyt3GQYCnIzf73GUDBlPwC/sl1W3a1a3qQ3EyCH75rem2zXcxa6DlFeXJxXUvBGh8yWOl8//0uoOATcQQSdPg6U2J9gbQPfs/ZvhfCSbszx8O18m+2pZ1JkvCz0jHVP/ChJqMODoelo46MFkuPV2XWQCoP2NA1Lkk1WLPYPMtJx0Agcu0xGnG/AUb4OMhJ9V4wuI2esfP3u02XHqNdmwUlCY+G8BfLTWX9e1Yxm86vsHWKniVehEdcRl3AV3ohMh7vdHwqI0y7TMOVT2QHjO8OyALaBmHKUnc1XFIdZgPAsiZORfWfP2HhO7H7p4WdOMAbf6VnnEGywEUvxB37LwY0eS5BwaOqQLiWQMVRdw3nzqhDOChO5D3ul8sAIEJrhB0MQBvrbwm/71xAUaEV1ox1M5mOmdkNvxkZnHiKw8PdNbrLzYicyap2u3Cs68RMm91iufz5oaXssyq7u2NyQ==;5:Ubi9qIG1JzjQlvVs63uwV/ulXDzycuhPIumPL7ckndvc4IxLYBvGJz/eVfSim/uncCCqwEcd+lqZkORSNBf37dM7447R/oGw6WDRr68HmuNT7q+nn4gHxa37Ud6CFnHCVXJkTOKfidVxDNrgYJKyaQ==;24:qeF5jQRz8K8L0+uQCC41eBNl49g+50mX8VSpogbZe5smqojYzxE9yysJrnR8MNYFsFNzpBEiyZvwoZ/C4TES/oxCTRJw7hAq9mPe5IjsCFA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DB5PR0201MB1863;7:yP0/Ia5TpJQ3geA9xtC//1W/cnLInf0nZpmogaBtqCxsSYs4bcICsC+vxnJ6OuW/05J45bK0lWllFDsO47RQDrZmcyg6fA8PtTtifyZdSLLRL3s3tMkPuVLnA74nIzw0hgZVlgfUFsSHVgONcRCTlMSEH0lXBK4skWGnrLOntMwr7tWp9JjTbpcZNPMwnMa7566vdvYW5Rp6Imap5QdI/WSI3pVYzJByO3rUBmvFGFuqMBWwdKFuqg5ktAXr0XOv6F4cEsAzpJ/rU+XEAF9BamwyoZ4FjBwvJlb95Cqpif8C35CUF1GmN50FwFWPx5vUsQ9HZY+GZmHf2UxqxtMzAA== X-OriginatorOrg: qt.io X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2017 14:40:34.7790 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR0201MB1863 X-SW-Source: 2017-q2/txt/msg00062.txt.bz2 Some compilers implicitly cast the result of uint_fast16_t * uint_fast16_t to something signed and then complain about the comparison to (unsigned) size_t. Casting phnum to size_t is a good idea anyway as 16bit multiplication can easily overflow and we are not checking for this. Signed-off-by: Ulf Hermann --- libdwfl/ChangeLog | 4 ++++ libdwfl/elf-from-memory.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/libdwfl/ChangeLog b/libdwfl/ChangeLog index cddafe2..c9bd4f0 100644 --- a/libdwfl/ChangeLog +++ b/libdwfl/ChangeLog @@ -1,5 +1,9 @@ 2017-04-20 Ulf Hermann + * elf-from-memory.c: Explicitly cast phnum to size_t. + +2017-04-20 Ulf Hermann + * libdwflP.h: Don't include config.h. * argp-std.c: Include config.h. * cu.c: Likewise. diff --git a/libdwfl/elf-from-memory.c b/libdwfl/elf-from-memory.c index dd42e95..12a0a1b 100644 --- a/libdwfl/elf-from-memory.c +++ b/libdwfl/elf-from-memory.c @@ -172,7 +172,7 @@ elf_from_remote_memory (GElf_Addr ehdr_vma, { /* Read in the program headers. */ - if (initial_bufsize < phnum * phentsize) + if (initial_bufsize < (size_t)phnum * phentsize) { unsigned char *newbuf = realloc (buffer, phnum * phentsize); if (newbuf == NULL) -- 2.1.4