From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id 30FA73858439 for ; Fri, 27 Aug 2021 16:31:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 30FA73858439 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from tarox.wildebeest.org (83-87-18-245.cable.dynamic.v4.ziggo.nl [83.87.18.245]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 295903000ADC; Fri, 27 Aug 2021 18:31:00 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 808AC413CE32; Fri, 27 Aug 2021 18:31:00 +0200 (CEST) Message-ID: <154bc07190017349bfb4ee941a5daf59c827508b.camel@klomp.org> Subject: Re: [PATCH] lib: remove unused `STROF` definition (NFC) From: Mark Wielaard To: Saleem Abdulrasool , elfutils-devel@sourceware.org Date: Fri, 27 Aug 2021 18:31:00 +0200 In-Reply-To: <20210827152013.4061770-1-abdulras@google.com> References: <20210827152013.4061770-1-abdulras@google.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Aug 2021 16:31:04 -0000 Hi Saleem, On Fri, 2021-08-27 at 15:20 +0000, Saleem Abdulrasool via Elfutils-devel wr= ote: > This definition was in the fallback path, where `sys/cdefs.h` is not > available. Now that we have a single path through here, this macro gets > defined, though is unused. Remove the unused macro definition. The STROF macro is not used, so this is indeed a NFC. Pushed. Thanks, Mark