From: Mark Wielaard <mark@klomp.org>
To: "Érico Nogueira" <ericonr@disroot.org>, elfutils-devel@sourceware.org
Subject: Re: [PATCH] Don't use locale functions when libintl header isn't included.
Date: Mon, 26 Oct 2020 23:22:32 +0100 [thread overview]
Message-ID: <16a3c067707f5b261be9e8080c7827265d9e775b.camel@klomp.org> (raw)
In-Reply-To: <C6N1TRF4YYBU.2JZ1MBT3BMUN7@mussels>
On Mon, 2020-10-26 at 15:53 -0300, Érico Nogueira via Elfutils-devel
wrote:
> I had talked with fche on #elfutils, and it was suggested that I could
> remove the locale functions from debuginfod.cxx. If you think it makes
> more sense to simply include the header (which is what I did initially
> for my own build), I guess I should remove the comment about C++ support
> as well, right? Or modify it to something else, at least. Would you have
> any suggestions for that?
Aha, I hadn't seen that before, you mean this line in debuginfod.cxx:
// #include <libintl.h> // not until it supports C++ << better
I think it is nice if all elfutils tools would use the same
print_version function so --version always produces the same thing.
I think that is the only "real" thing in debuginfod.cxx that uses
localization and I don't believe anybody actually submitted a
translation of that notice.
If so (you'll have to double check) and it makes things easier/cleaner
for debuginfod then you could remove the gettext call from
print_version and remove the textdomain calls (please also remove the
commented out include). Especially if Frank (fche) agrees.
But if it is all the same, then I would simply add the include for
libintl.h and remove or update the comment to say this is just form
calling textdomain for some C helper functions, but isn't used in the
C++ code (yet).
Cheers,
Mark
next prev parent reply other threads:[~2020-10-26 22:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 4:11 Érico Nogueira
2020-10-26 18:46 ` Mark Wielaard
2020-10-26 18:53 ` Érico Nogueira
2020-10-26 22:22 ` Mark Wielaard [this message]
2020-10-26 22:22 ` Frank Ch. Eigler
2020-10-26 22:44 ` Érico Nogueira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16a3c067707f5b261be9e8080c7827265d9e775b.camel@klomp.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=ericonr@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).