From: Mark Wielaard <mark@klomp.org>
To: Evgeny Vereshchagin <evverx@gmail.com>,
Aleksei Vetrov <vvvvvv@google.com>
Cc: elfutils-devel@sourceware.org
Subject: Re: [PATCH 2/2] libdw: Use elf_rawdata when checking .debug section
Date: Thu, 23 Feb 2023 11:20:43 +0100 [thread overview]
Message-ID: <1853091eea2fcabcbef97a5999809f3e48a3c7af.camel@klomp.org> (raw)
In-Reply-To: <3eb9eb567539cb118277be6ebc420dce6c55e0d9.camel@klomp.org>
Hi,
On Tue, 2023-02-21 at 12:24 +0100, Mark Wielaard wrote:
> On Tue, 2023-02-21 at 05:28 +0300, Evgeny Vereshchagin wrote:
> > On Mon, 20 Feb 2023 at 19:03, Aleksei Vetrov <vvvvvv@google.com> wrote:
> > > On Mon, Feb 20, 2023 at 3:55 PM Mark Wielaard <mark@klomp.org> wrote:
> > > >
> > > > .debug sections are raw bytes and don't need conversion even when host
> > > > and file have different endian order.
> > >
> > > Thank you! I like this patch more for its simplicity, looks good to me.
> >
> > Agreed. I haven't actually tested the patch though but since it's
> > covered by the fuzz
> > target it should be tested once it's merged anyway.
>
> I was actually planning on pushing both patches.
> This one makes sure the conversion code isn't called, because that is
> unnecessary in this case. The first patch adjusts the conversion code
> so it doesn't leave some undefined bytes in the section data.
I have pushed both now.
Cheers,
Mark
next prev parent reply other threads:[~2023-02-23 10:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 15:55 Fix some .debug checking and gnu hash xlate logic Mark Wielaard
2023-02-20 15:55 ` [PATCH 1/2] libelf: memmove any extra bytes left by elf_cvt_gnuhash conversion Mark Wielaard
2023-02-20 15:55 ` [PATCH 2/2] libdw: Use elf_rawdata when checking .debug section Mark Wielaard
2023-02-20 16:02 ` Aleksei Vetrov
2023-02-21 2:28 ` Evgeny Vereshchagin
2023-02-21 11:24 ` Mark Wielaard
2023-02-23 10:20 ` Mark Wielaard [this message]
2023-02-21 16:40 ` Aleksei Vetrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1853091eea2fcabcbef97a5999809f3e48a3c7af.camel@klomp.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=evverx@gmail.com \
--cc=vvvvvv@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).